Comments (4)
I think we can create an interface which is a collection of services and we can call these methods/services from do.go
from dunner.
here I have implemented the interfaces in Python to make it easy for us to work with. please refer the branch 'python-function-protos'
from dunner.
The current structure in approved in #12 is not quite according to the Golang standard accepted by the community. Have a look at this repo and this section of "Effective Go". Although it is not an official structure, but it has been developed by observing the trend in bigger projects in Golang.
A small possible restructure patch could be (including the test files as mentioned in my comment on #13 ),
.
+-- cmd/
| +-- do/
| | +-- do.go
| | +-- do_test.go
. .
.
+-- pkg/
| +-- services/
| | +-- config/
| | | +-- config.go
| | | +-- config_test.go
| | +-- docker/
| | | +-- docker.go
| | | +-- docker_test.go
. . .
. .
.
I will be ready a PR soon enough if someone approves the suggestion. Also, can this issue be re-opened?
from dunner.
@ayushjn20 I reopened the issue, you can send a PR
from dunner.
Related Issues (20)
- Show colored error messages
- Override mounts, envs from actual task by follow task HOT 2
- Add pointers to `dunner tasks` command result
- Not throw validation error for env not set when listing tasks HOT 1
- Git hooks not failing commit on vet errors HOT 1
- Container should be removed after execution of a step
- Live output in the case of non-concurrent(sequential) execution of steps
- Single string command parsing to docker
- Use Github actions to build and test Dunner HOT 2
- Ability to use private docker images
- Ability to use dunner with docker images whose entrypoint is defined HOT 5
- Dunner Unit tests in windows fail HOT 1
- Akkxhx HOT 2
- Add support for podman as backend for Dunner. HOT 3
- Dunner logo HOT 1
- Dunner Logo HOT 1
- Update Developer guide HOT 4
- `dunner do install` commands to quick install tools globally
- Ability to pass varying number of parameters to a command
- dunner installation as embedable wrapper HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dunner.