Serious BUG in IE about kohana-google-maps-module HOT 8 CLOSED

Hi Barat,
thanks for reporting!

I believe a solution may be changing JSON keys from:
var test = {key_1: 'value_1', key_2: 'value_2'};

to:
var test = {'key_1': 'value_1', 'key_2': 'value_2'};

I'll check, when I'm home and push a solution.

Thanks again!

from kohana-google-maps-module.

It's not json but your default view. There You make whole <script> thing, but You leave last comma in each array/params ;)

For example here:

https://github.com/solidsnake/Kohana-Google-Maps-Module/blob/master/views/gmap.php#L36-43

You will get last "," in array + Error in IE ;)

from kohana-google-maps-module.

Alright, I pushed a bugfix - I tested it in IE 7 and 8. I hope it works for you aswell :)

from kohana-google-maps-module.

I fixed it by my own, no json - just changed if/else places to not include comma if not needed ;)
But Your solluton may be cleaner ;)

Thnking about geocode function? For example getting lat/lng from given address? ;)

BTW. Polygon and Polylines can make same bug because of comas ;)

from kohana-google-maps-module.

Mh, I thought about it - yes... But I'm not sure if that stuff belongs in this module. Also I believe there's already another module for that.

If you're looking for some great Kohana modules, take a look at https://github.com/ahutchings/kohana-modules

from kohana-google-maps-module.

Yes I used and Fixed one plugin for geocode (deprecated functions, some bad checking etc) and placed it inside Your module ;)
But this is just a sugestion ;)

from kohana-google-maps-module.

Well, if it's fully integrated you could send me a pull request :D

from kohana-google-maps-module.

Can't - old module. I found this one - pretier, cleaner ... and I think that only thng it have to be done is changing name to geocode and maybe remove "key" part, because v3 doesn't need keys ;)
https://github.com/guillermin/gmaps

from kohana-google-maps-module.