Improving `Decoder` performance using `Read` trait. about message-io HOT 6 OPEN

Task management

@hasanhaja
Hi @lemunozm, thank you for the pointers! I'm looking into the code and getting a feel for what's going on now, and I'll circle back with questions soon.

Todo

NOTE: I will add more todos as my exploration develops.

• Familiarize myself with Read Trait
• Understand how the loop in the try_decode() method works or even what it's for

from message-io.

Hi @seonwoo960000,

It's just a matter of performance improvement. I'm not sure how much it can pump up the performance in real scenarios, to be honest. As far as I know, there is no work done on it right now

from message-io.

Hi, I'm new to the code base and I don't have any experience contributing to open source but I want to start and offer my help. Would you be able to give me some pointers on how I can get familiar with the code base enough to tackle this issue?

from message-io.

Hi @hasanhaja, thanks for your help!

This improvement is quite localized in the library and only two files should be updated:

• src/util/encoding.rs which contains the Decoder that should be modified adding the decode_from method. (some unit tests should be added too here to check this new method). The Decoder is in charge of accumulating the incoming data until that data represents a message.
• src/adapters/framed_tcp.rs where the FramedTcp transport is implemented and uses the Decoder (Only the receive() method should be modified). Currently, it makes use of the decode() method, and it should be changed by the new decode_from(). Also, this update will avoid the buffer usage of the receive() method.

To make this change. it is important to be familiar with the Read trait.

Do not hesitate to ask any doubt or any new ideas to tackle the problem. 😃

from message-io.

Hi @lemunozm, thank you for the pointers! I'm looking into the code and getting a feel for what's going on now, and I'll circle back with questions soon.

from message-io.

Hi @lemunozm , is this still relevant issue? 🤔

from message-io.