Packages contain code that will be rejected by a future version of Rust about message-io HOT 12 CLOSED

Hi @lemunozm,

I just wanted to ask when you could release a message-io version with the updated dependency :-)

All that's really needed is changing the Cargo.toml to use mio 0.8, which I did locally. All message-io tests run fine, so does my application.

Thanks!

from message-io.

Thank you!! That was quick!

from message-io.

Hi! I'm not able to check the error because I'm not in windows, and ntapi is only compiled there. I do not use this dependency directly in message-io, so it seems that there is any other dependency that includes that. I've updated all dependencies in this branch: dependencies-updated.

Could you please check if importing the updated version into your project still generates the issue?
To address to this specific change in Cargo.toml:

message-io = { git = "https://github.com/lemunozm/message-io", branch = "dependencies-updated" }

Thanks!!

from message-io.

Unfortunately that didnt fix it :(
I cant seem to track down the dependency in message-io that causes this, because of the limited output i am getting from cargo.
Perhaps we could use a [patch] like in message-io to get rid of this like cargo suggested? That would (rather forcefully) get rid of the outdated dependency.

from message-io.

If thats a valid option i'd make a PR :)

from message-io.

To be honest I've never dealt with this problem, but if that patch works, I'm fine with the PR 😃

from message-io.

After trying to fix this i just noticed that i cannot [patch] the version of a dependency's dependency :(
The only way to fix this is to actually track down what dependency includes ntapi and then file a PR/Issue there

from message-io.

I will try to track down the dependency if i have some free time, but at the moment i have lots of work to do so no idea when i will get around to doing it - I'll keep you updated

from message-io.

Thanks for the info 😃. One question, a cargo tree in Windows does not show the ntapi dependency somewhere?

from message-io.

You can use cargo tree --target x86_64-pc-windows-gnu on linux, the dep is coming from mio

Mio already have replaced those deps with windows-sys in latest version tokio-rs/mio#1556

from message-io.

Thanks, @sigmaSd, for the advice!
Seems like it's time to update mio to version 0.8. I'll try to get some time to do it.

from message-io.

Done! Published version 0.14.7 with mio version 0.8

from message-io.