Comments (12)
Hi.
It seems the internal thread is still running when you do ctrl+c. You should call NodeHandler::stop()
before. To perform clean exits when the user makes ctrl+c I recommend https://github.com/Detegr/rust-ctrlc to handle the signal before the OS kill the process
from message-io.
Ok but if i un DiscoverServer in a tokio task, I also ctrlc::set_handler(...
in main
outside of that task.
How would I access discovery
or dsserver
?
from message-io.
This depends on how your architecture is built. I would send an event that the task could receive. Also, the NodeHandler
is clonable and sendable, so you could store any copy of them where you want to then call .stop()
before the program exits.
from message-io.
indeed i clone the entire DiscoveryServer
(that implements run()
and stop()
)
This is what I do in main
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3ed82949b6852827866aaf5ee6cc07cf
I run the server in a tokio task and i catch a ctrlc signal from main and call stop()
from the cloned Arc<Mutex>
I see a signal has been catched but nothing is actually stopped
from message-io.
I checked the code and it seems the mutex is locked at line 29, before you perform the stop() called. Could you try to move the println() after this line and check if it's printed?
from message-io.
yes i already tried that and indeed it prints
Mutex { data: <locked>, poisoned: false, .. }
from message-io.
the discovery.run() does something like
pub fn run(&mut self) -> std::io::Result<()> {
let node_listener = self.node_listener.take().unwrap();
node_listener.for_each(move |event| match event.network() {
...
...
from message-io.
If I understand well the code you pasted and you shared now, your run()
call will keep processing forever (until you call stop()
). During this processing, the mutex is locked, so, when you try to lock again to make the stop()
call, it is already locked. If your problem is getting the NodeHandler
under the mutex, remember that you can clone it, and then use the cloned NodeHandler
without making the lock()
from message-io.
Exactly, run()
runs forever.
How can i call stop() directly if that's behind a Mutex
?
from message-io.
A solution could be:
- Create your DiscoveryServer instance.
- get the
NodeHandler
from the discovery server and clone it. - Create the mutex over the discovery server.
- lock() and call run().
- use the node_handler.stop() (which is out of the mutex) at ctrl_c signal.
from message-io.
You only need to clone NodeHandler
which is already clonable, you do not need to clone the entire DiscoveryServer.
from message-io.
lol it worked! It's a bit ugly but thank you so much!!
from message-io.
Related Issues (20)
- Unable to connect with FramedTcp HOT 1
- Release v0.15.0 HOT 8
- Add support for Bevy ECS HOT 3
- Error compiling with only tcp feature enabled HOT 3
- Release 0.16.0 HOT 2
- Buymeacoffee badge is misspelled ("bymeacoffee") HOT 1
- ws can not receive text HOT 10
- Is it possible to limit max packet size when using FramedTcp transport? HOT 1
- Is it possible to create an UART adapter? HOT 3
- Not compiling on linux (ubuntu 22.04) HOT 2
- Scaling of a application HOT 6
- is there any possibility for multiple thread mio eventloop? HOT 1
- Feature Request: Accept WebSocket URLs with parameters. HOT 3
- client don't try reconnect HOT 2
- Code very similar to the example does not work HOT 6
- Trait implementation of adapters that cannot accept a socket address? HOT 3
- Build error with Tungstenite 0.22.0+ HOT 1
- add set_reuse_port to tcp and framed_tcp HOT 1
- TCP, FramedTCP message send is not truly async HOT 3
- iOS target build complains undefined function bind_device in TCP protocol HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from message-io.