Comments (8)
Thanks for the detailing the error. You are right, it's a problem to the whole wss indendently of the text/binary modes.
I was looking into it and after making the TCP connection, it sends a HTTP request (used for plain WS) instead of a TLS hello (used for WSS). So it tries to connect a normal socket to the tipical WSS port 443 and the server refused the connection.
It's a bug, and I think it is not fast fordward to resolve, because seems that tungstenite do not add the TLS layer automatically for you when connect with wss
schema and use the non-blocking handshake mode. It's a pity because for blocking mode tungstenite adds this TLS layer automatically, but message-io works uses only the non-blocking mode.
I hope to fix it in the future, but I cannot promise in a near future. For now, I will remove it as a feature of message-io
So sorry the inconvenience :( and thanks to notify the error
from message-io.
I'm currently in maintenance mode on this repo. By now, I'm not developing new features. Sorry!
Nevertheless, if anyone wants/can do it I'm open to it.
from message-io.
Hi @temclaugh,
It seems a bug, I will investigate it.
Thanks for notifying!
from message-io.
I look more deeply into the use case. The problem is that message-io uses WebSocket in binary
mode and the echo.websocket.org
expected in text mode. At this moment there is no way to configure it to use the text
mode. This configuration property would depend on #54
Sorry for the inconvenience, I will notify it in the README.
from message-io.
Hi @lemunozm, thanks for looking into this!
Iβm wondering if itβs possible that this is related to TLS specifically? ws
connections seem to work fine on the same host where wss
does not. Example:
use message_io::network::{NetEvent, Transport, RemoteAddr};
use message_io::node::{self, NodeEvent};
fn main() {
connect("wss://echo.websocket.org".to_string());
connect("ws://echo.websocket.org".to_string());
}
fn connect(url: String) {
let (handler, listener) = node::split::<()>();
handler.network().connect(Transport::Ws, RemoteAddr::Str(url.clone())).unwrap();
listener.for_each(move |event| match event {
NodeEvent::Network(NetEvent::Connected(e, success)) => {
if success {
println!("{} successfully connected", url);
handler.network().send(e, b"foo");
} else {
println!("{} failed to connect", url);
handler.stop();
}
}
NodeEvent::Network(NetEvent::Message(_, x)) => {
println!("{} received message: {}", url, String::from_utf8_lossy(x));
handler.stop();
}
_ => (),
});
}
Output:
wss://echo.websocket.org failed to connect
ws://echo.websocket.org successfully connected
ws://echo.websocket.org received message: foo
It looks like something might be going wrong during the handshake.
Or, if I'm understanding this incorrectly, is the issue that text mode is causing the handshake to fail, and that would be fixed in binary mode?
Just as a point of reference, I'm able to communicate with echo.websocket.org
using websocat
with all combinations of ws
, wss
--binary
and --text
from message-io.
Is this something which will still be addressed ?
from message-io.
Tungstenite has the client_tls() method, which automatically adds a TLS layer if needed. Could that be used to solve the issue?
from message-io.
Maybe that can be used to implement the adapter with TLS support ππ»
from message-io.
Related Issues (20)
- Disconnecting badly acting client (endpoint) HOT 2
- Cancelling timed messages fails sometimes HOT 3
- Release 0.14.8
- Unable to connect with FramedTcp HOT 1
- Release v0.15.0 HOT 8
- Add support for Bevy ECS HOT 3
- Error compiling with only tcp feature enabled HOT 3
- Release 0.16.0 HOT 2
- Buymeacoffee badge is misspelled ("bymeacoffee") HOT 1
- ws can not receive text HOT 10
- Is it possible to limit max packet size when using FramedTcp transport? HOT 1
- Is it possible to create an UART adapter? HOT 3
- Not compiling on linux (ubuntu 22.04) HOT 2
- Scaling of a application HOT 6
- is there any possibility for multiple thread mio eventloop? HOT 1
- Feature Request: Accept WebSocket URLs with parameters. HOT 3
- client don't try reconnect HOT 2
- Code very similar to the example does not work HOT 6
- Trait implementation of adapters that cannot accept a socket address? HOT 3
- Build error with Tungstenite 0.22.0+ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from message-io.