Button Handling OSX about speculos HOT 7 CLOSED

Thanks for the clarification! Indeed, it looks like a bug in speculos, related to this io_seproxyhal_button_push().

from speculos.

As mentioned by @mul1sh, the bug can be reproduced on the sia app (it isn't related to OS X and can be reproduced on Linux too), for instance in the ui_getPublicKey_compare_button() callback with the following APDU:

echo 'e002000000' | LEDGER_PROXY_ADDRESS=127.0.0.1 LEDGER_PROXY_PORT=9999 ledgerctl send -

When a button is pushed (either left or right), UX_REDISPLAY() is called, then UX_REDISPLAY_IDX() and eventually io_seproxyhal_init_button(). io_seproxyhal_init_button() sets G_ux_os.button_mask to 0.

When the button is released, the callback (ui_getPublicKey_compare_button()) is called with button_mask being equal to BUTTON_EVT_RELEASED, because:

• G_ux_os.button_mask = 0 because of io_seproxyhal_init_button()
• button_mask = G_ux_os.button_mask | new_button_mask; (L910)

The condition BUTTON_EVT_RELEASED | BUTTON_LEFT | BUTTON_RIGHT is thus never met.

I guess it works on a real device because of some race condition?

from speculos.

@mul1sh does #62 fix the issue?

from speculos.

@greenknot unfortunately no as explained in the PR. i'm also using the headless option with docker, not sure if that can be an issue too.

from speculos.

@greenknot no worries, glad I could help. Thanks.

from speculos.

I've really now idea how it can work on a real device and it's indeed a bug in speculos since the behavior differs. That being said, the sia app uses some legacy UX primitives and I guess this behavior can be fixed (in the sia app) using what's called flow now IIRC, or more conventional button callbacks.

I don't plan to spend more time on this issue, feel free to re-open it if these suggestions don't work for you.

from speculos.

@greenknot no worries and thanks for the feedback. I think i'll just improvise with other button events moving forward.

Also just out of curiosity what do you mean legacy UX primitives, sounds like the security risk no? Since even the official docs recommend to start developing from the sia app.

from speculos.