LeBlender Editor Property Validation about leblender HOT 5 OPEN

I've added in the option for a property to be required now. After implementing it, I looked through the code and found some references to "mandatory" validation - but I can't see where this is used at all or how one would go about setting a property up to be mandatory.

Was this a feature that was never fully implemented or have I just reinvented the wheel?

For reference (and anyone interested in implementing it too) I have added a Required checkbox to the parameterconfig.prevalues.html file binding to property.value.required. And then in the parameterconfig.controller.js inside the property loop within $scope.isValid i've added:

if (property.$editor.required && property.value == null) { isValid = false; property.error = "This field is required"; return; } else { property.error = null; }

I then output this below each property in parameterconfig.html:
<div ng-if="property.error">{{property.error}}</div>

I haven't created this as a pull request because I'm still unsure as to whether this functionality is new and perhaps I've just not figured out how to activate it?

from leblender.

@tomeglenn a PR would be grealy appreciated

We have talked about this a bit, but not really found a good solution yet

from leblender.

@tomeglenn Can you please provide me with some more details on exactly what you changed to do this? I have tried but it just errors or are there different changes to make it work in the latest version of LeBlender & Umbraco?

from leblender.

Hi @jacklawry ,

Apologies for the delayed response. I never saw @soreng's request to make a PR, apologies.

I don't have a fork of LeBlender setup on my machine but I do have the commit log from when I implemented the functionality so I will explain it below.

App_Plugins/LeBlender/editors/leblendereditor/dialogs/parameterconfig.controller.js

Find the following if statement

if (!property.$valid)
	...
}

Directly after that if statement closes, add a new one containing the following.

if (property.$editor.required && property.value == null) {
	isValid = false;
	property.error = "This field is required";
	return;
} else {
	property.error = null;
}

App_Plugins/LeBlender/editors/leblendereditor/dialogs/parameterconfig.html
Find this line:

<blender-editor-wrapper property="property" item="item"></blender-editor-wrapper>

Directly after it add this line:

<div ng-if="property.error">{{property.error}}</div>

App_Plugins/LeBlender/editors/leblendereditor/dialogs/parameterconfig.prevalues.html
Find this section:

<umb-control-group label="Description" description="">
	...
</umb-control-group>

Directly after that, add this:

<umb-control-group label="Required" description="">
	<div style="text-align: left">
		<input type="checkbox" ng-model="model.value.required" />
	</div>
</umb-control-group>

You should now be able to go into your LeBlender properties editor and mark fields as required.

Hope this helps.

from leblender.

This is now working thanks @tomeglenn!

from leblender.