Git Product home page Git Product logo

Comments (8)

lebaston100 avatar lebaston100 commented on June 4, 2024

I'm going to take a look into it tomorrow.
I know that the code is so messy that i don't expect anyone else to work on it but without looking into it further, it might have to work like a fader where the value is replaced before sending.
I will get back to you.

from miditoobs.

ptitodd avatar ptitodd commented on June 4, 2024

Actually, that's a great idea. I was looking at OBS_on_message():84 ToggleSourceVisibility. And that seemed (to me) like the most logical place to start and then I got lost in the array that gets pulled from the config.json. I am also adding in 'program_change' as the the LPD8 and wireless LPD8 have toggles that allow pads to send program change messages. They work like all the other messages just with no velocity or value and they drop in with any of the button functions.

from miditoobs.

lebaston100 avatar lebaston100 commented on June 4, 2024

So i took a look into the code and i'm going to implement it.
What would you preffer in terms of the string that get's added to the url. It should not break any website. I was thinking about something like "#" or maybe "?".
? could confuse a few sites that use post vars.
Or maybe let the user choose?

from miditoobs.

ptitodd avatar ptitodd commented on June 4, 2024

What if we just toggle the url between http://urlstring.dom/#refresh and http://urlstring.dom/

My only concern is that Anchor Tags ("#") shouldn't 'technically' reload a page, it reloads browser-source now, it may not reload in a future update (doubt it, but ya never know). But the queries ("?") do, in my opinion, represent a bigger potential for an issue as you've suggested. Could totally mess with some sites.

I like the keep it simple aspect of MIDItoOBS so I don't think it's necessary to let the user choose. We can always update the script if OBS makes a dramatic change.

from miditoobs.

lebaston100 avatar lebaston100 commented on June 4, 2024

Ok so then we'll use # for now. Give me a few days (maybe into the weekend) and i'll push it as soon as it works.
If someone has a problem with the #, they can just open an issue and i can tell them to change the symbol inside the code that should be enough for now.

from miditoobs.

lebaston100 avatar lebaston100 commented on June 4, 2024

So i added it in 36552d5

from miditoobs.

lebaston100 avatar lebaston100 commented on June 4, 2024

I will close this in a week, feel free to comment or reopen if needed.

from miditoobs.

ptitodd avatar ptitodd commented on June 4, 2024

haven't had an opportunity to test it. but I can open a new issue if it's not working, Thanks for the addition

from miditoobs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.