[Meta] Improve contribution workflow about pokedex HOT 9 CLOSED

I think @Brene makes a good point. I definitely contributed straight to one of the branches, but there is no CONTRIBUTE.md yet.

On the other hand, I think @schickling is onto something with keeping the git flow as simple as possible.

As such, would it make sense to stick with what we've got and at least try a CONTRIBUTE.md? (and be SUPER explicit) At least for the moment I imagine %99 of all PRs coming internally and as such keeping it simple will speed things up.

from pokedex.

What's the downside of just working on the master branch and discouraging people from doing PRs for the generated branches?

from pokedex.

Because people will change everything and then in the end, when they actually want to commit it, they'll realize that they should work on the master branch. This could decrease the motivation of creating pull requests.

from pokedex.

I think this is rather a matter of clear communication. I worry that introducing a pull-branches.sh opens a whole new level of potential problems. But I'm open to try it 👍

from pokedex.

What problems do you see in pull-branches.sh?

from pokedex.

Two-way merging is way more complicated and error prone than a unidirectional workflow.

from pokedex.

Agree! Do you guys quickly want to draft a CONTRIBUTE.md?

from pokedex.

Done :)

from pokedex.

I still think the first two bullet points have to be adressed

• fix the inconsistencies brought up by PR #6, its merging and the force push done by update-branches.sh
• fix other inconsistent branches. these include at least step-01, step-01-solution and step-05

@Brene, can you help me out here?

from pokedex.