`/project list`: Players can list projects that have been or need to be reviewed about echo-cli HOT 16 CLOSED

Moved the completed stuff to #33

from echo-cli.

Updated description based on guide content produced in LearnersGuild/learning-os-software#120

from echo-cli.

Yeah. It would be interesting data to compare the quality of the code on a single project across cycles, too.

from echo-cli.

By "hold back" I mean "let's wait to implement this until after the 15th."

from echo-cli.

@tannerwelsh -- please review this issue description and make mods as necessary.

from echo-cli.

Updated the description to change the flags a bit. Seems like /project list --completed should show me projects I've completed, not the reviews.

To list the reviews I've given, I would expect that to be /review list --completed or something along those lines. Not critical for v0. So long players can see the list of projects up for review along with whether and how they've reviewed them.

Note: the --completed flag can be pushed to v1 if necessary. Also not critical, just outlined here to distinguish between previous incarnation.

from echo-cli.

@tannerwelsh, @jeffreywescott: it seems strange to me that /project list doesn't actually list any projects. Am I reading that right?

Also curious how we determine if a project is finished or not. Does the team manually mark it as complete? Or are we scraping some project duration value from the github issue and doing the math?

from echo-cli.

Oh, or do we consider it complete once there's an artifact URL?

from echo-cli.

Yes, you're reading the /project list correctly -- we're future-proofing it to (eventually) support things like listing the projects that the player in question has completed themselves, e.g. --completed.

It seems to me that if we're in the REFLECTION state for a cycle, any project associated with that cycle is now "fair game" to review. We may want to send a "nag" to players on teams who haven't yet set their artifact-url once we enter the REFLECTION state.

from echo-cli.

Ok, so a single project could be reviewed multiple times by the same person, once every cycle. I guess it makes sense to let people review projects in progress, not just at the end.

from echo-cli.

Okay, @tannerwelsh, @bundacia and I just spoke again about this, and there are some things about it that are still weird. Specifically, the way you've written-up the UX sort of hints-at or implies that projects have a state, and they don't, really.

Assumptions:

• (not for v0, but in the schema / design) projects may span multiple cycles
  • if a project spans multiple cycles, the project team may change from cycle-to-cycle
• cycles have a state, like: GOAL_SELECTION, PRACTICE, REFLECTION, or COMPLETE
• a project doesn't really have a state
  • a project is considered complete if all of the cycles it is associated with are in the COMPLETE state
  • a project is either complete or active -- there's not really a way for a project to be "in review"

So -- questions:

1. Do we really want to use this --in-review option and "in review" language? There's functionally no difference between "in review" and "active".
2. Should projects be reviewed every cycle, even if they are only part-way through. For example, if a project spans 4 cycles, and it's 1 cycle in, should it be reviewed? (It would seem so, since the team may change and we may eventually want to associate the scores [quality, completeness] with those team members, right?)

from echo-cli.

@jeffreywescott, @tannerwelsh: I suggest we hold this back for week 1. Players can see the status of a review using the /review #project command and the first week there will only be a handful of projects, so the moderator can easily remind everyone what they are in the chapter channel at review time.

I think there are more important things to focus on.

from echo-cli.

@bundacia -- is there something below this in the "To-Do" lane that you think is more important (aside from the improved retro stuff)?

from echo-cli.

See also: LearnersGuild/los#24

from echo-cli.

Related: LearnersGuild/los#39

from echo-cli.

Get the list of projects with name, artifactURL, and the list of player ids who've completed the project review in the most recent cycle.

r.db('game_development')
  .table('projects')
  .map(function (proj) {
    return proj.merge({
      reviewCompletedBy: r.db('game_development')
        .table('surveys')
        .get(proj('cycleHistory').nth(-1)('projectReviewSurveyId'))('completedBy')
    }).pluck('name', 'artifactURL', 'reviewCompletedBy')
  })

from echo-cli.