if user changes email address in GitHub, echo sign-in will create a new user about echo-chat HOT 5 CLOSED

So, this is interesting. Email is how we look you up when you log into idm in the first place. So if a player changes their email in GH (and removes the old one) IDM will assume they have no account at all. We could lookup by username instead, but that can be changed also. It seems like maybe we need to lookup users by their GH id?

from echo-chat.

+1 for github ID. seems the only reliable way to go here, especially since the messaging in the UI is around authentication via github specifically.

from echo-chat.

blocked by LearnersGuild/idm#127

from echo-chat.

This branch should fix the issue, but it will be easier to test once idm#127 is live

from echo-chat.

In practice what will happen if you change your email address is that when you try to sign in to echo it will try to create a new account with the same username and fail with this error:

[lg-sso] error signing-in using SSO on idm service Error: Username already exists. [403]

Which to the user looks the same as every other login failure.

from echo-chat.