last three tests don't pass about js-looping-and-iteration-looping-code-along HOT 10 CLOSED

As of commit: 638635a

If I run npm test I get, in my browser:

Am I missing something?

from js-looping-and-iteration-looping-code-along.

Here are some screenshots of the test not passing.
The code that they wrote was the one they copied and pasted from the Solution Branch.

from js-looping-and-iteration-looping-code-along.

@sgharms this is one of a handful of lessons that pass with the learn-co browser test system but fail when using regular mocha testing. Investigating why this happens.

from js-looping-and-iteration-looping-code-along.

So this happens because when you stub Math.random in a mocha file it copies your file-specific version of Math.random that got spun up as a requirement. It seems this issue also plagues new Date, if we use that in any other tests.

Overcoming it is apparently possible, but incredibly crufty. Here's a git repo walking through the process using mockery: https://github.com/newz2000/dice-tdd

My personal recommendation is to change the lab to utilize non-randoms. It would probably be less work than making this one work, and the amount of additional code interwoven into the normal lines would likely be very confusing for student.

Here's a screenshot of my specific failure pre-attempting to fix it:

As you can see, the function is returning different values for numbers of tails flipped pretty consistently, but the test itself isn't stubbing the correct Math.random instance, and therefore is failing to recognize that it is called, or force specific return values.

from js-looping-and-iteration-looping-code-along.

Good research @RylanBauermeister . It's so strange that it works on some machines but not others, I wonder if the internals of rand() have changed between OS versions or some such. In any case, the reversion of the merge commit that brought in the random seems like a good strategy.

from js-looping-and-iteration-looping-code-along.

from js-looping-and-iteration-looping-code-along.

@geluso I believe the learn-browser dependency is the culprit. It's designed to de-scary mocha+chai ecosystem and is set up to look at a virtual DOM as a measure of success (ideal for dom-based challenges). we're testing to see if jettisoning that dep removes the breakage.

from js-looping-and-iteration-looping-code-along.

Another example for this issue learn-co-students/js-looping-and-iteration-looping-code-along-nyc-web-career-031119#12

from js-looping-and-iteration-looping-code-along.

Hey @geluso,

I've pushed up the rewritten content for this lab, removing the reliance on Math.random() and changing the tests and narrative a bit so this should no longer be an issue. Thanks for reporting!

from js-looping-and-iteration-looping-code-along.

Copy that! Saw the PR.

from js-looping-and-iteration-looping-code-along.