Git Product home page Git Product logo

Comments (8)

leandrowd avatar leandrowd commented on July 22, 2024

Hi @web2style, this project is a bit old and needs to be cleaned and tidied up. If you go to the folder /lib you will find the version you want. I'm not updating the main package.json only the one within /lib.

It also is the reason you can't install from the root. Try from /lib.

Let me know if it helps.

I'm currently not able to spend time on this project. Let me know if you are keen on helping.

from react-responsive-carousel.

yantakus avatar yantakus commented on July 22, 2024

Why keeping 2 versions at the same time? This means I made my pull request to a wrong file: src/components/Carousel.js instead of lib/components/Carousel.js. This is absurd.

from react-responsive-carousel.

leandrowd avatar leandrowd commented on July 22, 2024

No, you did it right. /lib contain generated files. The npm package is the lib folder.

from react-responsive-carousel.

yantakus avatar yantakus commented on July 22, 2024

Got it. But how then I can use the latest master version from github if lib/components/Carousel.js doesn't include my changes?

from react-responsive-carousel.

leandrowd avatar leandrowd commented on July 22, 2024

Just run gulp package and it will generate the files for you.

https://github.com/leandrowd/react-responsive-carousel#generating-the-package-for-npm

from react-responsive-carousel.

yantakus avatar yantakus commented on July 22, 2024

Thanks for quick answers. Hm, but how can this be done automatically upon npm install? There's no postinstall script in package.json.

from react-responsive-carousel.

leandrowd avatar leandrowd commented on July 22, 2024

That can't be done automatically. gulp package is only for local development. What you need is the package to be published again. I will publish when I have some spare time.

For now, you can use it locally.

from react-responsive-carousel.

leandrowd avatar leandrowd commented on July 22, 2024

Hi @web2style, your previous PR were published to npm. Check version 3.0.11.

I've updated the node version needed for the build as well. If you use 0.10.36 through nvm it should be fine.

Thanks for your contributions and feedbacks.

from react-responsive-carousel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.