Git Product home page Git Product logo

Comments (12)

leandrocfe avatar leandrocfe commented on August 9, 2024 1

Theme set to dark mode
image

image

Theme changed to light mode.
image
image

@leandrocfe, procede?

Sim, eu vou remover e deixar somente pela classe. Tenho umas melhorias pra lançar junto com isso. Acho que até a próxima semana 👍

from filament-apex-charts.

gotzsys avatar gotzsys commented on August 9, 2024 1

Hi @leandrocfe, sorry for the late reply, the adjustment worked out well, thank you very much!

from filament-apex-charts.

andrewdwallo avatar andrewdwallo commented on August 9, 2024

Can confirm that this does happen sometimes. I tried to use the "title" option and the same thing happened. I have to switch from dark back to light mode many times for the black text to show instead of white.

from filament-apex-charts.

valpuia avatar valpuia commented on August 9, 2024

Check this out.. I submit issue but found a solution

#25 (comment)

from filament-apex-charts.

andrewdwallo avatar andrewdwallo commented on August 9, 2024

It's not really a solution though. #9ca3af is essentially the only color that you can use for legend labels, etc... only because the color looks okay in both light and dark. I think it would be a lot better if dark mode was actually supported with chart text, but I'm not sure how that would be done unless the package owner decided to override something from apex charts.

from filament-apex-charts.

andrewdwallo avatar andrewdwallo commented on August 9, 2024

So, in my opinion, it may not be an issue, but I think it is definitely a flaw...

from filament-apex-charts.

gotzsys avatar gotzsys commented on August 9, 2024

The problem is here...
/resources/views/widgets/components/chart.blade.php

image

localStorage.getItem('theme') || (document.documentElement.classList.contains('dark') ? 'dark' : 'light')

from filament-apex-charts.

andrewdwallo avatar andrewdwallo commented on August 9, 2024

I'm not sure if that is the actual issue but I actually found a solution by overriding the CSS class of whatever I am trying to use in filament.css like this:

.apexcharts-title-text {
    fill: #111827;
}

.dark .apexcharts-title-text {
    fill: #ffffff;
}

This actually looks promising to me for many things considering the CSS of almost everything in apex charts is not influenced by TailwindCSS at all.

from filament-apex-charts.

gotzsys avatar gotzsys commented on August 9, 2024

Theme set to dark mode
image

image

Theme changed to light mode.
image
image

@leandrocfe, procede?

from filament-apex-charts.

gotzsys avatar gotzsys commented on August 9, 2024

Boa, muito obrigado @leandrocfe !
Abraço e bom final de semana

from filament-apex-charts.

leandrocfe avatar leandrocfe commented on August 9, 2024

Boa, muito obrigado @leandrocfe !
Abraço e bom final de semana

Valeu. Bom fim de semana

from filament-apex-charts.

leandrocfe avatar leandrocfe commented on August 9, 2024

Hi @gotzsys,
Would you like to try this version?

composer require leandrocfe/filament-apex-charts:"^2.0"

from filament-apex-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.