Lua 5.3 support about pgmoon HOT 9 CLOSED

If you want to get around the require error you can install luabitop from luarocks for your corresponding version of lua.

I now remember why I wrote a wrapper library for this purpose - you actually can't do that. The dependencies of luabitop requires lua >= 5.1, lua < 5.3.

I wrote this a while ago for minimal support. I can rebase it from the latest master and people can specify that in their rockspecs until then.

from pgmoon.

This seems to be related: luarocks/luarocks#526

from pgmoon.

btw, when we do fix this, we need to turn on lua5.3 on ci:

https://github.com/leafo/pgmoon/blob/master/.travis.yml#L14

If you enable it and run ci now you can see why it's currently not working

from pgmoon.

I'm pretty new to Lua, but from my understanding, this line should not contain the word 'require'.
Also, the following line probably needs some small changes since - from what I read - the integrated "bit" library is not a drop in replacement for the external one.
I tried to propose a patch for this today, but I did not found anywhere an example on how to identify the lua version at runtime. I think the clean way to support 5.1, 5.2, and 5.3 would be to identify the version and behave differently based on that

from pgmoon.

Sorry, I left out some information. There are other reasons why specs don't pass on 5.3, it's not a simple change to require to fix it. If you want to get around the require error you can install luabitop from luarocks for your corresponding version of lua.

It's listed as a dependency: https://github.com/leafo/pgmoon/blob/master/pgmoon-dev-1.rockspec#L16

I'm guessing you didn't install pgmoon via luarocks?

from pgmoon.

Should pgmoon migrate from luabitop to bit32 now that Lua 5.2+ supports native 32 integers and related ops?

from pgmoon.

https://github.com/AlberTajuelo/bitop-lua looks like a neat library that includes a luabitop compatibility layer

from pgmoon.

I would support a fix for this as well, this blocks Lua 5.3 compatibility e.g. for https://github.com/Kong/kong.

from pgmoon.

Closing old issues. Lua 5.3 support has been available for quite some time now, test suite has been updated to reflect that.

from pgmoon.