Git Product home page Git Product logo

Comments (9)

calvinmetcalf avatar calvinmetcalf commented on August 22, 2024

This seems like overkill, making a minified version is probably more helpful, then having customizable script generator if we want to cut down on the size of it.

from leaflet-providers.

jieter avatar jieter commented on August 22, 2024

I still like this idea...

Screenshot of the POC I use locally:
2013-07-09-105218_1175x758_scrot

Minified/generated versions still require me to download a file, put in in the right place and include it in my HTML.

We have a tidy 'repository' of tilelayer providers, with correct attributions and min/maxZoom. Why not make it available this way for this different use case?

from leaflet-providers.

calvinmetcalf avatar calvinmetcalf commented on August 22, 2024

oooh i see I had thought you wanted to have it build a file to download open up a pull request

from leaflet-providers.

jieter avatar jieter commented on August 22, 2024

;)

Need to think about a way to include all layers without explicitly putting them in the file (easy) and without overflowing the not-so-huge screens though...

from leaflet-providers.

jieter avatar jieter commented on August 22, 2024

Just pushed https://github.com/leaflet-extras/leaflet-providers/tree/preview-page , please take a look.

The disctinction between baselayers/overlays is lost if we do not explicitly define them, we could add some key to the list of providers which indicates that it is an overlay...

from leaflet-providers.

calvinmetcalf avatar calvinmetcalf commented on August 22, 2024

overlay is only really important if your putting it into a layer control so the distinction isn't necessarily meaningful here

from leaflet-providers.

jieter avatar jieter commented on August 22, 2024

Not only then:
For example: reviewing the weather layers doesn't make much sense without a baselayer, so it would be nice if some basemap as reference is present.
But not really important...

from leaflet-providers.

calvinmetcalf avatar calvinmetcalf commented on August 22, 2024

true it would be nice to be able to select a couple layers, I meant that the code that is given doesn't change if it's an overlay or a base (As far as I know)

from leaflet-providers.

jieter avatar jieter commented on August 22, 2024

true, but I would fix that if we can decide on a way to distinguish between the two.

We could just make a list in the preview.html code referring to overlay layers and insert those in the control as overlay layers. Thus we do not have to add unnessecary stuff in the provider definition...

from leaflet-providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.