Git Product home page Git Product logo

Comments (2)

msageryd avatar msageryd commented on July 17, 2024

I have the same problem. Tried to debug this.. Not sure of how to solve it though.

The problem is in react-native-view-pager. initialPage is set correctly at first, but when the page is validated in scrollToPage() via this.validPage() it gets reset to 0 because at that stage there are no pages (this.pageCount == 0). validPage protects against this and resets currentPage to 0.

The pageCount is initialized at render(), which is too late when one wants to set initialPage. I'd like to move dataSource cloning and pageCount updating to componentWillReceiveProps(). But there seems to be need for width and height before dataSource cloning. These are not achieved until onLayout, which is before WillReceiveProps. I'm not sure why height and width are needed before cloning the datasource..

As a workaround for now I have actually remarked the call to validPage(). I'll have to make sure that initialPage < number of pages, as there is no protection for this now.

Not-very-nice-workaround, remark row 248:
https://github.com/ldn0x7dc/react-native-view-pager/blob/master/library/ViewPager.js#L248

from react-native-gallery.

msageryd avatar msageryd commented on July 17, 2024

Here is a little better work around:
ldn0x7dc/react-native-view-pager#4

from react-native-gallery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.