Change CobraModel to FullModel about cobrexa.jl HOT 6 CLOSED

Coo, I'll make a branch today and implement it!

from cobrexa.jl.

Possible semantic issue (feel free to disregard, but I need to write it down somewhere)-- FullModel is going to became an invalid name at any point when anyone adds anything new to any other model. We should really try to assign some quality that describes it properly. For me it now combines something like GenomicModel and StandardizedMetabolitesModel. But that sounds just bad.

from cobrexa.jl.

I agree for the most part. I think LinearModel, CoupledLinearModel and SBMLModel are well named, but this one is tricker... it doesn't help that it's so close to SBMLModel in terms of content. Although it is meant to store any kind of cobra model [json, mat, xml, yml] and keep all the "extra" information, e.g. grrs.

I could come around to GenomeModel like you suggested... Or StandardGenomeModel or StandardModel?

from cobrexa.jl.

👍🏼 for StandardModel

from cobrexa.jl.

JK, fixed in #53 :)

from cobrexa.jl.

Also, changing the name to StandardModel solves my minor issue in #38

from cobrexa.jl.