Name functions consistently with JuMP style? about cobrexa.jl HOT 6 CLOSED

I think we should stick with camel case: https://docs.julialang.org/en/v1/manual/style-guide/#Use-naming-conventions-consistent-with-Julia-base/

from cobrexa.jl.

So they recommend camel case for Modules and structs, but underscores for functions where appropriate. See the excerpt from the the Julia docs:

• modules and type names use capitalization and camel case: module SparseArrays, struct UnitRange.

• functions are lowercase (maximum, convert) and, when readable, with multiple words squashed together (isequal, haskey). When necessary, use underscores as word separators. Underscores are also used to indicate a combination of concepts (remotecall_fetch as a more efficient implementation of fetch(remotecall(...))) or as modifiers.

• conciseness is valued, but avoid abbreviation (indexin rather than indxin) as it becomes difficult to remember whether and how particular words are abbreviated.

Also, JuMP recommends underscores, see excerpt from their docs below:

Use of underscores within names

The Julia style guide recommends avoiding underscores "when readable", for example, haskey, isequal, remotecall, and remotecall_fetch. This convention creates the potential for unnecessary bikeshedding and also forces the user to recall the presence/absence of an underscore, e.g., "was that argument named basename or base_name?". For consistency, always use underscores in variable names and function names to separate words.

from cobrexa.jl.

good point 😄 let's stick with that convention then 👍🏼

from cobrexa.jl.

so we are renaming to snake_case if I get it right?

from cobrexa.jl.

yes, according to the convention @stelmo posted

from cobrexa.jl.

Fixed by 4aa8a97

from cobrexa.jl.