Make sure the accessors for MetabolicModel kinda feature-complete about cobrexa.jl HOT 10 CLOSED

I think metabolites have only compartment, not subsystem. And reactions have subsystem

from cobrexa.jl.

correcting

from cobrexa.jl.

hmm are we going to use plural or singular for these accessors? E.g. gene_notes or gene_note and metabolite_annotations or metabolite_annotation?

Plural makes more sense to me...

from cobrexa.jl.

Also, they should all return vectors of things by default or dicts?

I would say vectors, but always in order of whatever reactions, metabolites or genes returns

from cobrexa.jl.

annotations already have the type Dict{AnnotationType, Vector{AnnotationValue}} where the AnnType and AnnValue are strings. That exists for each object in question.

No idea about notes now. In SBML I've got a Maybe{String} for that, but not sure if that's right.

from cobrexa.jl.

we need an id(model) accessor to get the id of a model

from cobrexa.jl.

also reaction_names, gene_names and metabolite_names

from cobrexa.jl.

JSONModel, MATModel, SBMLModel etc. are not consisten about this. We need to decide and specify exactly which functions are generic and implement them across all models.

from cobrexa.jl.

almost done, are we going to play with the names too?
(actually, the meaning of "names" is kindof subsumed by having a note that says roughly "this has names XXX, also known as YYY")

from cobrexa.jl.

I'm slashing the names, the scheme is perfectly clear now and we can add them whenever we actually need them later.

from cobrexa.jl.