Git Product home page Git Product logo

Comments (5)

bones7242 avatar bones7242 commented on September 24, 2024 1

@Invariant-Change could you take a look at this?

from spee.ch-components.

QuirkyRobots avatar QuirkyRobots commented on September 24, 2024

Re: calc(100vh - 3em); is a conflict of interest

  • em = Relative to the font-size of the element.
  • vh = Relative to 1% of the height of the viewport.

This means the image can only be as big as 100% of the screen size minus 3em of the text size.

So when you zoom in, the image shrinks by the same em increments that the text increases, and because of the max height is 100vh - 3em, which is less than 100% of the screen size, it never zooms bigger.

It would be best to leave sizing natively to the browser. Most browsers do a good job with images, initially putting 100% of it in view with a zoom button to make it 100% of the image size while retaining the screen zoom in and out functionality.

And as @kauffj pointed out, the image size should be included in the HTML for improved speed and better image control.

Hope that helps :)

from spee.ch-components.

QuirkyRobots avatar QuirkyRobots commented on September 24, 2024

As for the "Hosted via Spee.ch" part not interfering with the screen/image size and adding scrollbars, this would work nicely...

a#asset-boilerpate .speech-logo {
    position: fixed;
    right: 0;
    bottom: 0;
    background: #444;
    padding: 1px 12px;
    color: #afdae4;
    border-radius: 4px 0 0;
    border-top: 1px solid #555;
    border-left: 1px solid #555;
}

image

from spee.ch-components.

alyssaoc avatar alyssaoc commented on September 24, 2024

@skhameneh can you take a look at this? Will the solution work, can/should it be implemented quickly?

from spee.ch-components.

skhameneh avatar skhameneh commented on September 24, 2024

Still valid and the layout requires other changes for this; doesn't look to be an easy solution because of the flex layout we use.

from spee.ch-components.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.