Git Product home page Git Product logo

Comments (1)

rtomlinson-latacora avatar rtomlinson-latacora commented on August 17, 2024

Hey AJ,

Thanks for taking a look at the code. I'll make some improvement using your stylistic and syntactic recommendations.

The reasoning I had for implementing the lock was the the GCP DNS API only allowed me to make requests for changes, but does not actually block until the change has been made. This was causing issues regarding certs with wildcards. It seemed that for some of the DNS provider APIs that a change request would wait until the change was completed before returning. I didn't see anything in the Greenlock code base that addressed this, but I most definitely could have missed it.
Are you suggesting that maybe instead of implementing the lock that I could query the existing change requests and see if the request had been made? I feel that that approach is a little more brittle, but I could look into it.

Thanks again

from acme-dns-01-gcp.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.