Git Product home page Git Product logo

Comments (8)

davidblewett avatar davidblewett commented on July 22, 2024

It appears something in that commit is not interacting well with my use case ( see https://gist.github.com/davidblewett/53047c4c7757b663c11b ). When I run lp-ssh-add.sh now, the script hangs on L23 for the very first key and is unkillable with Ctl-C. I have to kill it from another shell. As long as the script is running, it's generating thousands of files in ~/.lpass/upload-queue. Why is just dumping the contents of different keys triggering an upload of anything?

from lastpass-cli.

bcopeland avatar bcopeland commented on July 22, 2024

Hmm, not sure yet - but note output of show has changed for secure notes, you don't need to use grep anymore because these notes are parsed and you can extract them with --field.

from lastpass-cli.

bcopeland avatar bcopeland commented on July 22, 2024

Regarding output differences:

  • Notes field will now have an extra newline
  • Passphrase will now have an extra leading space

I think what's happening is the latter causes ssh-askpass to fail (provide wrong passphrase) and so ssh-add gets stuck in a loop asking for it over and over again. See my updated gist which may fix things for you (although you also might want to come up with a way to abort the process if lp-ssh-askpass is failing).

upload-queue gets used to log accesses for history/auditing purposes (see cmd-show.c:226).

from lastpass-cli.

davidblewett avatar davidblewett commented on July 22, 2024

I think I've solved my issues in the gist; still surprised it's possible to generate gigabytes of this audit log.

from lastpass-cli.

bcopeland avatar bcopeland commented on July 22, 2024

Yes, perhaps we should rate limit it somehow - once it gets over some threshold just error out so one doesn't get stuck sending us gigabytes of updates.

from lastpass-cli.

glyph avatar glyph commented on July 22, 2024

I also ran into this problem, after changing my master password. No ssh-agent loop in my case, I just tried to create a new item with lpass generate and lpass info, and it happily generated gigs of upload-queue on its own. Sadly I deleted the ~/.lpass directory so I don't have a copy of the buggy state, but it does seem to be working fine now.

from lastpass-cli.

wkoszek avatar wkoszek commented on July 22, 2024

@bcopeland Looks like this issue is solved. Can we close the issue?

from lastpass-cli.

cizmazia avatar cizmazia commented on July 22, 2024

Possibly related #265

from lastpass-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.