TOLAdAdapteriAds was deallocated while key value observers were still registered with it about larsadcontroller HOT 5 CLOSED

There is already functionality built into LARSAdController to support delayed deallocing of adapter instances. It appears that the adapter is returning YES from -canDestroyAdBanner Since the only requirement from that method is that isBannerViewActionInProgress returns NO. -canDestroyAdBanner looks like the best place to add more logic for delayed destruction.

from larsadcontroller.

@larsacus, thanks for the reply. How would that stop [self.adapterInstances removeAllObjects] from just clearing all the adapters?

from larsadcontroller.

What is the actual bug being encountered? I assume you're calling destroyAllAdBanners for a reason.

from larsadcontroller.

The error is the title of this report. I call destroyAllAdBanners when an ad-free purchase is made. Unfortunately, it it appears the method is destroying the adapters before getting a chance to turn off notifications. My changes seem to be working.

from larsadcontroller.

I apologize, the title was truncated in my email, and I didn't look at it again when I came here.

The solution is actually much simpler than that:

- (void)destroyAllAdBanners{
    NSArray *instances = [self.adapterInstances allValues];

    for (id <TOLAdAdapter> adapterInstance in instances) {
        if (adapterInstance.adVisible) {
            [self animateBannerForAdapterHidden:adapterInstance withCompletion:^{
                [self cleanUpAdAdapter:adapterInstance];
            }];
        }
        else{
            [self cleanUpAdAdapter:adapterInstance];
        }
    }
}

-cleanUpAdAdapter: will handle everything needed to remove that instance from its storage arrays and remove all observers. I've updated master with this change.

from larsadcontroller.