Git Product home page Git Product logo

Comments (7)

larsacus avatar larsacus commented on June 27, 2024

Do you have this in a branch I can clone and try out?

from larsadcontroller.

larsacus avatar larsacus commented on June 27, 2024

Is this the full implementation of the adapter? Or is there a branch I can try out?

from larsadcontroller.

Fred10932 avatar Fred10932 commented on June 27, 2024

Hi Lars
Sorry was out for the weekend. I have a branch ready but need collaborator status to upload.

from larsadcontroller.

larsacus avatar larsacus commented on June 27, 2024

If you have a fork of the project, you can push the branch up to your own fork.

from larsadcontroller.

Fred10932 avatar Fred10932 commented on June 27, 2024

OK -- see RevMob branch @ https://github.com/Fred10932/LARSAdController.git

from larsadcontroller.

larsacus avatar larsacus commented on June 27, 2024

I guess I'm really not sure what the specific issue is, but I did clean it up a bit. Check out my RevMob branch.

I'm not sure what it's supposed to look like in landscape as right now all it does is stretch the test ad.

from larsadcontroller.

Fred10932 avatar Fred10932 commented on June 27, 2024

Thanks. I also tested some live banners with your solution and indeed RevMob (there are only a few varieties) doesn't adapt its banners to more screen real estate, they just stretch out.
I think constraining the banner to a 320 (iPhone) or 768 (iPad) width may be the way to go for this adapter after all.

from larsadcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.