Git Product home page Git Product logo

Comments (3)

aruhant avatar aruhant commented on July 30, 2024 1

I have submitted a PR to fix this.
Kindly review and merge #376 when you get a chance.

from upgrader.

larryaasen avatar larryaasen commented on July 30, 2024

@aruhant I created a unit test to show this failure and I was not able to get it to fail. I duplicated the test testing lookupById with redesignedVersion in file play_store_test.dart and changed the app id from com.testing.test4 to com.testing.test8, and duplicated the file test_play_store_page4.txt as test_play_store_page8.txt, and changed the title in 6 places throughout the file from:

US Debt Now - National Debt

to:

US Debt Now - “National’s” Debt

The test did not fail.

Can you put a unit test in your PR that shows it failing if run without your code change?

from upgrader.

larryaasen avatar larryaasen commented on July 30, 2024

I fixed this issue and it will be available in the next release 10.1.0.

from upgrader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.