Comments (3)
I have submitted a PR to fix this.
Kindly review and merge #376 when you get a chance.
from upgrader.
@aruhant I created a unit test to show this failure and I was not able to get it to fail. I duplicated the test testing lookupById with redesignedVersion
in file play_store_test.dart and changed the app id from com.testing.test4
to com.testing.test8
, and duplicated the file test_play_store_page4.txt as test_play_store_page8.txt, and changed the title in 6 places throughout the file from:
US Debt Now - National Debt
to:
US Debt Now - “National’s” Debt
The test did not fail.
Can you put a unit test in your PR that shows it failing if run without your code change?
from upgrader.
I fixed this issue and it will be available in the next release 10.1.0.
from upgrader.
Related Issues (20)
- Does it support for internal testing app also ? HOT 4
- Question on minAppVersion from stores with multiple locales HOT 1
- How to specify minAppVersion using appcast instead of playstore? HOT 1
- I used the updateAvailabe() method from the upgrade.sharedInstance to check if an update is available, but it consistently returns false even when a new version of the app is available in the respective store
- Please upgrade package_info_plus to ^8.0.0 HOT 5
- Add privacy manifest file for iOS HOT 1
- Pressing Upgrade doesn't open link. HOT 8
- Minimum tag on play store not working. HOT 5
- Do not pop the dialog when 'Update' is clicked. HOT 5
- Issue: Show duplicate alert HOT 3
- How do I enforce custom logic that the upgrader only show for higher MAJOR or MINOR not for PATCH?
- Helo
- Production version is 11.07 and Update is availble for 11.8 then it is not showing dialog how do i show dialog
- Update alert not showing
- Support to kyrgyz language(code: "ky")
- Queries regarding usage of this package
- `UpgradeCard` disappears / never appears if `upgrader` is changed
- Inlining Upgrader config ("upgrade" param) ignores the config
- Mandatory update popup won't show after closing the app
- Testflight issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from upgrader.