Git Product home page Git Product logo

Comments (8)

larryaasen avatar larryaasen commented on June 23, 2024

@skol101 I assume the iTunes API is returning an empty response when the app is not available on the US App Store. In that case, there is no version of the app to upgrade, and thus there should not be a message or alert displayed to the user. Can you explain more about your issue, including the messages from the log, and possibly any screenshots?

from upgrader.

skol101 avatar skol101 commented on June 23, 2024

The issue is that the plugin or iTunes Api call doesn't check whether app is available on other markets. For instance, if I just open https://apps.apple.com/app/id1478293930 in the browser, the App Store will open even when the app isn't available on the US app store.

from upgrader.

larryaasen avatar larryaasen commented on June 23, 2024

What country codes are valid for the 1478293930 app?

from upgrader.

skol101 avatar skol101 commented on June 23, 2024

We've made it available in the US with the recent update, though not in Russia ('ru' I believe).

from upgrader.

larryaasen avatar larryaasen commented on June 23, 2024

This package is not designed to handle App Stores outside of US. However, it may not be that difficult to add country support. The URL used by the iTunes class is:
https://itunes.apple.com/lookup?id=1478293930
which default the county to US. When I added the query parameter country=RU,
https://itunes.apple.com/lookup?id=1478293930&country=RU
it returns no results:

{
 "resultCount":0,
 "results": []
}

This URL https://itunes.apple.com/lookup?id=1478293930&country=CA seems to return the Canadian store listing.

I may be able to get the store country ID from a plugin and use that in the URL. Let me look into that.

from upgrader.

hivesey avatar hivesey commented on June 23, 2024

Hi,
I would like to express interest in having this plugin working for apps in the store outside the US too. Is that fix underway?

Thanks,

from upgrader.

larryaasen avatar larryaasen commented on June 23, 2024

@hivesey This package does not support multiple countries for iOS. It only supports the US app store at this time. However, there is a quick patch you could make if you want to support only one country that is not US. To make that patch, fork this repo, and change the following line to the country code of your choice:

_countryCode ??= 'US';

from upgrader.

larryaasen avatar larryaasen commented on June 23, 2024

@skol101 @hivesey There is an update to this package that now supports using the country code from the locale, which merged in PR #39. Check it out.

from upgrader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.