This package causes App Engine deployments to fail. about comments HOT 11 CLOSED

Hi, I'm glad that you like it.

I don't know what may be causing your issue. The package does not use or depend on any cache...

I have a new version (not yet ready for a release) in the 'develop' branch. Maybe that release will work for you. I have made a few changes there and plan to implement more changes.

Do you want me to ping you when it will be ready? My guess is this weekend.

from comments.

Absolutely. I plan on adding a bunch of things to it like rate limiting (to keep the trolls at bay) and I was going to see if I could auto update the comments via pusher. Once done, I’ll send a PR. Hopefully it’ll fit your intended purpose and coding style so it can be useful to you.

from comments.

That would be nice. Thank you

from comments.

Just an update.

I haven't had the time the last weekend for this package, but I am working on creating a blog that will use this package and I think that once I start implementing comments in it, is when I will update this package. I'll let you know.

from comments.

Appreciate it. I am going to be taking a crack at getting these comments to work again this week. I really don't want to make my own. But I need to figure out exactly which dep is causing the deployment issue. Unfortunately, the logs are huge and messy during appengine deployments. And it doesn't give me much insight into exactly what is failing.

Was also thinking of upgrading from L5.7 to 5.8 with the latest version of Spark. But we'll see. I'm sure it will be a pain.

from comments.

After almost a month of pulling out my hair because i don't know what caused error (i have lots of other package installed too), I finally found the problem on my own and only after that I found this page.

The issue is not the caused by this package itself, but rather it seems like the problem with combined implementation of this package, laravel and App Engine lol

In short, I could confirm the particular line that caused this issue is

Blade::component('comments::components.comments', 'comments');

I don't really know what happen behind the scene, but I guess laravel cache blade components, and App Engine tried to do it in the "cloud builder", which is not a prod/dev environment, so it cannot access laravel files, therefore the error.

The solution? I did this and it works

if (!\App::runningInConsole()){
	Blade::component('comments::components.comments', 'comments');
}

from comments.

How cow @drionix. You are a beast. I couldn’t even find detailed enough logs to trace it down.

Also, kudos to you. It sounds like you’re in appengine standard env? I’m working on getting memcached and other services working with L5.8. PM me if you’ve got any ideas.

Thanks again!

from comments.

Maybe this will help you: https://cloud.google.com/community/tutorials/run-laravel-on-appengine-standard

See the part where it says APP_STORAGE and VIEW_COMPILED_PATH.

Also check the beyondcode/laravel-dump-server removal step.

It seems to me that laravel will cache views and logs and appengine does not allow it to write to /storage. Let me know if these steps work for you.

from comments.

Maybe this will help you: https://cloud.google.com/community/tutorials/run-laravel-on-appengine-standard

See the part where it says APP_STORAGE and VIEW_COMPILED_PATH.

Also check the beyondcode/laravel-dump-server removal step.

It seems to me that laravel will cache views and logs and appengine does not allow it to write to /storage. Let me know if these steps work for you.

Actually, I build my web based on that tutorial. Everything was fine until around 2 months ago. However, I only noticed the error about 1 month ago since app engine always cache what it builds.

As this package has no 'suspicious' commits in the last 1 month, I know that the problem must be from laravel or app engine.

And like I said previously, somehow I found out that laravel seems to cache blade components, and App Engine Cloud Build tried to parse it in the "cloud build" environment, which probably is a separate environment (not in a prod/dev environment), so it cannot access laravel files and therefore the error.

In conclusion, it is not the problem with this package. However, it would be awesome if you could help mitigate this issue by modifying

Blade::component('comments::components.comments', 'comments');

in ServiceProvider.php to

if (!\App::runningInConsole()){
	Blade::component('comments::components.comments', 'comments');
}

from comments.

@drionix Thank you for explaining, but I don't like adding this code to my package to patch this specific issue.

Currently I am working on a new version in which I have replaced:

Blade::component('comments::components.comments', 'comments');

with

Blade::include('comments::components.comments', 'comments');

Can you try using the package with that change and see if it works for you then?

Update:

As a workaround you can opt-out of package discovery, create a service provider for comments in which you extend the package service provider, change the line in question and register your service provider in config/app.php.

from comments.

Try the latest release: https://github.com/laravelista/comments/releases/tag/3.0.0

from comments.