Comments (8)
Just for clarification, we have the default configuration:
'trim' => [
'lottery' => [1, 1_000],
'keep' => '7 days',
],
Also, I'm trying to check the code to see how it works, because to my eyes, it's not clear how the lottery works. If I discover how it works, I may make a PR to the documentation to help.
from pulse.
Hmm it seems there is a bug. I used xdebug and it never hits the trim method.
If I remove ... from trim() here it works. It is already inside a closure :)
https://github.com/laravel/pulse/blob/1.x/src/Pulse.php#L314
//either do
->winner(fn () => $this->rescue($ingest->trim(...))
//or
->winner(fn () => $this->rescue(fn () => $ingest->trim()))
@didac-adria You can restart with php artisan pulse:restart
from pulse.
This already exists: https://laravel.com/docs/10.x/pulse#trimming
from pulse.
Yeah I know @driesvints , but it's not working on our side. Maybe I don't understand the documentation. We have records almost a month old. I think the maximum age is 7 days.
from pulse.
@driesvints We've been trying to investigate how it works but we don't reach solid conclusions:
1- We've tried to reduce the lottery to see if it prunes the records automatically. It doesn't
2- We have tried to add some logs to check for errors. We don't see any.
We have also realized that we have to manually restart the deamon from forge in order to make it get the new php code after each deployment.
So:
1- Can you give us a hint about how the flow works to make it clean and why 'lottery' => [1, 1],
doesn't work?
2- Maybe we need a system to be able to restart the deamon of pulse:check in each deployment, the same way there is one for horizon.
Thanks in advance!
from pulse.
Oh great! I'm adding pulse:restart to our deployment hooks. Thanks!
from pulse.
Closing this as we have a fix up.
Heads up that this mainly impacts apps writing directly to the database and not using the performance focused Redis ingest.
Sorry for the troubles, folks.
from pulse.
Hey team!
Thank you all for your contributions!
See you!
from pulse.
Related Issues (20)
- redis cluster not supported for ingesting data HOT 6
- Support for sqlsrv HOT 3
- Locking and Trimming HOT 2
- Memory leak when running tests. HOT 1
- Running mysql command "optimize" fails on pulse_aggregates HOT 2
- Just an idea: Recording request data when logging exceptions HOT 1
- internal hooks HOT 1
- Feature request: ability to configure how many days of data is kept in pulse entries HOT 4
- Pulse significantly slows down Laravel Octane when using multiple CPU cores HOT 7
- SQLSTATE[HY000]: General error: 1 no such column: true HOT 6
- Feature Request: Extend nav bar with items HOT 2
- Enhancement Request: Customizable Context Tags for Monitoring Entries. HOT 1
- Dashboard with empty screen HOT 2
- Pulse Scalability rocks! - extract Pulse data repository? HOT 1
- Change logo for the dark theme HOT 1
- Integrate Pulse into Nova? HOT 1
- TypeError in `Pulse::rememberUser()` (Logout Event) HOT 1
- 500 Server Error displaying HOT 1
- UI issue (supports-scrollbars:pr-3) HOT 1
- Unexpected Alpine.js Errors in Laravel Pulse Dashboard HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pulse.