Git Product home page Git Product logo

Comments (6)

sandervanhooft avatar sandervanhooft commented on June 8, 2024

Thanks, but not a fan of this. Rather provide the ability to inspect and modify the package migrations by default.

from cashier-mollie.

lexdewilligen avatar lexdewilligen commented on June 8, 2024

Well you could still do so right? But also provide the autoload option

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 8, 2024

It tends to introduce a number of issues honestly, so it's not common practice to use this in Laravel packages. I feel like the loadMigrationsFrom() method should be dropped altogether tbh.

from cashier-mollie.

lexdewilligen avatar lexdewilligen commented on June 8, 2024

Ok, thanks for you reply!

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on June 8, 2024

No problem, really appreciate the contribution ❤️

from cashier-mollie.

lexdewilligen avatar lexdewilligen commented on June 8, 2024

Could you perhaps provide me with some issues that occur when using migrations autoloading? I don't really understand why providing this would give an issue. It's just an extra feature. If I were to write a PR that doesn't change your current workflow, but does implement loadMigrationsFrom(), would you accept it?

from cashier-mollie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.