Git Product home page Git Product logo

Comments (10)

marcklingen avatar marcklingen commented on August 22, 2024 3

Hi @khareyash05, back then there was no outbound email setup. Now it can be reused from the user invite email notifications.

Implementation thoughts

  • need to create a token and store in db
  • send deep link via email that includes the token
  • password reset page that works unauthed and checks token
  • use same implementation for change password (currently signed in) and password reset (forgot password) -> both use cases get email to reset the password on public page

Further thoughts

  • some users are SSO users, some even on SSO only domains (see env var). Those users should not be able to set a password or reset it as they should stick to SSO for security (eg 2FA)

from langfuse.

marcklingen avatar marcklingen commented on August 22, 2024

Happy to help/contribute, find me on the langfuse Discord: https://langfuse.com/discord

from langfuse.

DIWAKARKASHYAP avatar DIWAKARKASHYAP commented on August 22, 2024

I am working on creating a new "User Settings" page.

from langfuse.

DIWAKARKASHYAP avatar DIWAKARKASHYAP commented on August 22, 2024

is this design is ok for 'user settings' page
image
You can add additional features in the future, such as billing, support, contact us, account deletion and more

from langfuse.

khareyash05 avatar khareyash05 commented on August 22, 2024

Hi @marcklingen I was thinking on working on this issue. May I I please know as to why the above PR was closed so that I can improve on the same? Thanks

Working on it!

from langfuse.

khareyash05 avatar khareyash05 commented on August 22, 2024

Oh Lots to be done on the server side! Can I segregrate the work in smaller PR's? Thanks for taking time to explain the full process

from langfuse.

marcklingen avatar marcklingen commented on August 22, 2024

Sure. However you like. I'd suggest to create one draft PR and a single "password-reset" branch for this whole issue and then create sub/stacked PRs for the individual pieces. Happy to give feedback on each if you like. Just @ me

from langfuse.

khareyash05 avatar khareyash05 commented on August 22, 2024

Sure! This is the UI for the user settings page #760. Also there would be lot of questions to ask and lots of reviews to be done. Where can I ask them?

from langfuse.

flxwu avatar flxwu commented on August 22, 2024

Hi @khareyash05, back then there was no outbound email setup. Now it can be reused from the user invite email notifications.

Implementation thoughts

  • need to create a token and store in db
  • send deep link via email that includes the token
  • password reset page that works unauthed and checks token
  • use same implementation for change password (currently signed in) and password reset (forgot password) -> both use cases get email to reset the password on public page

Further thoughts

  • some users are SSO users, some even on SSO only domains (see env var). Those users should not be able to set a password or reset it as they should stick to SSO for security (eg 2FA)

@marcklingen any specific reason for the design choice on a db-persisted tokens here, instead of a JWT? (ofc, there are advantages & drawbacks)

from langfuse.

marcklingen avatar marcklingen commented on August 22, 2024

released recently, need to add smtp and from email address to env to enable this

from langfuse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.