Comments (8)
@picnicsecurity you can see the branch on the pr page, update-selector-for-upload-page-rewrite
So your commands should be
git clone [email protected]:lambtron/emojipacks.git
cd emojipacks/
git remote add jackellenberger [email protected]:jackellenberger/emojipacks.git
git fetch jackellenberger update-selector-for-upload-page-rewrite
git checkout --track jackellenberger/update-selector-for-upload-page-rewrite
from emojipacks.
Hi! this is fixed with #155
There aren't any contribution guidelines so I don't know if we should @ someone to get a review. If no one is around in another few days I'll start shoutin'.
from emojipacks.
@picnicsecurity
- this issue here is not about the PR at #155 which has it's own comments section for exactly those problems that happen with the changes introduced by the PR (although both the issue and the PR had the same motivation for being created)
- I'd never expect the way you tested this to work as PRs have rarely branched of the exact commit you are cloning when you found the PR on github. So you want to (as always with git) make sure that you have the exact commit the PR is about and definitely dont't want to apply the changes yourself. To checkout the exact commit, just do
git clone <therepositoryurl>
git remote add <github-user-name-of-user-that-made-pr> <repositoryurl-of-fork-with-pr>
git fetch <github-user-name-of-user-that-made-pr>
git checkout <branch-name-of-pr>
### Now you are on the very changeset that the PR is about
### and are actually able to test if it works or not
from emojipacks.
Thank you so much for your help :D
from emojipacks.
I just tested it by uploading ~500 emojis to our new slack space..... :ohcibi:
from emojipacks.
this never got pushed to master it would seem. Also emojipack no longer seems to work after your changes. I am probably doing something wrong though. I installed node and npm and then did a git clone. I went into the directory and changed the two files you changed. Then I ran make. Now whenever I run the command emojipacks, it does not output anything at all and just returns. Do you have any insight on if I am doing this wrong?
from emojipacks.
Hi @picnicsecurity! It' hasn't been reviewed so I don't want to get it into master just yet. make
shouldn't have anything to do with it, I think that's just for CI testing. I would double check that the diff on lib/slack.js
is identical, or just checkout the branch itself. As for no output - are you giving emojipacks an input? It should ask for a slack org, username, password, and a source yaml of emoji to upload. Are you getting to the step where those are asked for?
from emojipacks.
I am still learning git so forgive my silly questions here. What would be the url of the repository with the pr?
root@:~# git clone https://github.com/lambtron/emojipacks.git
Cloning into 'emojipacks'...
remote: Counting objects: 1106, done.
remote: Total 1106 (delta 0), reused 0 (delta 0), pack-reused 1105
Receiving objects: 100% (1106/1106), 4.47 MiB | 0 bytes/s, done.
Resolving deltas: 100% (480/480), done.
Checking connectivity... done.
root@:~# cd emojipacks/
root@:~/emojipacks# git remote add jackellenberger https://github.com/lambtron/emojipacks/pull/155
root@:~/emojipacks# git fetch jackellenberger
fatal: repository 'https://github.com/lambtron/emojipacks/pull/155/' not found
root@:~/emojipacks# git remote remove jackellenberger
root@:~/emojipacks# git remote add jackellenberger https://github.com/lambtron/emojipacks/pull/155/commits/3651dd8aaafbcd3fe22c25742e55e73cd63a8dcd
root@:~/emojipacks# git fetch jackellenberger
fatal: repository 'https://github.com/lambtron/emojipacks/pull/155/commits/3651dd8aaafbcd3fe22c25742e55e73cd63a8dcd/' not found
root@:~/emojipacks#
from emojipacks.
Related Issues (20)
- UnhandledPromiseRejectionWarning error HOT 14
- Allow importing of aliases from emojipacks HOT 1
- Write a script to update slackmojis.com emojis
- Support for teams with SSO enabled? HOT 5
- Add prefixes for slackmoji packs HOT 4
- CLI does not allow easily path interpretation HOT 3
- Found 11 errors in packs/hipchat.yaml HOT 3
- Failing Silently HOT 3
- FYI: Emojipacks is for-profit
- emojipacks for Discord?
- emojipacks fails after the most recent slack update HOT 18
- Failing after entering email HOT 3
- Can't get emoji crumb with 2FA signin HOT 4
- Batch Upload - Permission Denied HOT 10
- Error: Application Error: unable to find api token on login page HOT 1
- Does this have support for google sign in ? HOT 1
- Uh oh! Error: Login error: could not get login form for https://workspacename.slack.com HOT 4
- Add BetterTTV emoji pack
- Telegram
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emojipacks.