Git Product home page Git Product logo

Comments (5)

LagoLunatic avatar LagoLunatic commented on May 28, 2024 1

Huh, dang, I must've screwed something up when I refactored stuff to work with fileless sprites for 1.8.0.
Seems to also affect Death and Bat Company.

The Peeping Eye thing seems like it could be a different bug. It only deleted the parts for two frames, 24 and 25, instead of screwing up the order of basically all frames and animations and deleting some frames. And 1.7.1 still deleted parts for those two frames as well.

from dsvedit.

LagoLunatic avatar LagoLunatic commented on May 28, 2024 1

Turns out it was caused by the presence of "unanimated animations", when I added support for those I must not have tested it on the DS games very much because I forgot about a quirk of how sprite keyframes are read there.

Also, for the Peeping Eye thing, turns out that's not a bug at all. Peeping Eye's vanilla sprite just has some duplicate frames used in animations, and my darkFunction importer merges all duplicates so it resulted in frames 24 and 25 being "deleted" (not literally deleted since that would screw stuff up, just their parts are deleted).

from dsvedit.

LagoLunatic avatar LagoLunatic commented on May 28, 2024

I tried on Peeping Eye in DoS (which has 2 GFX pages) and it seems to work correctly. It imports as expected if I modify the animation frames, or the parts, and also if I don't modify anything and immediately re-import it.

Some more information that might help me reproduce it: What exact sprite are you modifying? What edits are you making to the sprite? Uploading the three files (.anim .png and .sprites) after you've modified them with darkfunction might help.

from dsvedit.

piratesephiroth avatar piratesephiroth commented on May 28, 2024

It happened with multiple sprites including Peeping Eye
Notice that it has 0x4E parts. Export and re-import and it now has 0x4C.

The more pages the sprite has, the bigger the problem becomes, affecting also the frame count.
Try with a playable character and you'll see it breaks nearly all of their animations.

I decided to test older versions and saw it worked fine on v1.7.1
https://drive.google.com/file/d/1nu3oi3OmtobLjf5cvWbkoljBkp2xMKBk/view

from dsvedit.

piratesephiroth avatar piratesephiroth commented on May 28, 2024

Here's my files (Julius's with the running animation from Harmony of Despair) just in case you want to try reimporting modified data.

DoS_julius_RUN.zip

from dsvedit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.