Git Product home page Git Product logo

Comments (12)

daniellAlgar avatar daniellAlgar commented on July 18, 2024 2

I was also having this problem. I solved it by adding android:nestedScrollingEnabled="true" to my ViewPager.

from viewpagerbottomsheet.

hynra avatar hynra commented on July 18, 2024

Wrap your ViewPager with NestedScrollView:

<android.support.v4.widget.NestedScrollView
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:fillViewport="true"
            app:layout_behavior="@string/appbar_scrolling_view_behavior">

            <android.support.v4.view.ViewPager
                android:id="@+id/bottom_sheet_viewpager"
                android:layout_width="match_parent"
                android:layout_height="match_parent" />
        </android.support.v4.widget.NestedScrollView>

from viewpagerbottomsheet.

gcobc12632 avatar gcobc12632 commented on July 18, 2024

@hynra
this can avoid the exception.
but my listview in ViewPagerBottomSheet can't scroll anymore.

from viewpagerbottomsheet.

laenger avatar laenger commented on July 18, 2024

Is this reproducible with (corresponding adjustments inside) the example app from this repository?

from viewpagerbottomsheet.

huzaifaiftikhar avatar huzaifaiftikhar commented on July 18, 2024

@laenger I'm also getting the same issue. If I use the same layout in the example app it works. However in my app it crashes with this error. If I remove viewpager from my layout the app doesn't crash. However on adding the viewpager it crashes!
I'm trying to integrate your library in Open Food Facts android app.

from viewpagerbottomsheet.

laenger avatar laenger commented on July 18, 2024

Looking at this again, it seems that #24 fixed this.

from viewpagerbottomsheet.

huzaifaiftikhar avatar huzaifaiftikhar commented on July 18, 2024

I tried this fix already before it was merged. It seems to fix the error since we do a null check however the viewpager doesn't scroll anymore. If I try to scroll down the bottom sheet collapses. Maybe I am doing something wrong. Please help!

from viewpagerbottomsheet.

laenger avatar laenger commented on July 18, 2024

Again, without a minimal reproducible example, it is very difficult to dig deeper into this. It would be great if you could modify the example app such that it runs into the described issue.

from viewpagerbottomsheet.

danponce avatar danponce commented on July 18, 2024

I was having the same crash and it was because I wasn't adding any fragment to the view pager. Be sure to check that you're adding some fragment to the view pager so it can initiate right

from viewpagerbottomsheet.

jobburg avatar jobburg commented on July 18, 2024

I have the same problem and a reprodcution path. You need to use a PagerAdapter instead of a FragmentPagerAdapter to reproduce it.

from viewpagerbottomsheet.

beelancrp avatar beelancrp commented on July 18, 2024

@daniellAlgar This solution is not correct, because of incorrect work of behavior.
I found a better solution for this bug. Try to use ViewPager.post { BottomSheetUtils.setupViewPager(viewPager) }.

Think it would be helpful. But need to understand how to fix it in lib.

from viewpagerbottomsheet.

beelancrp avatar beelancrp commented on July 18, 2024

For a better understanding, I show you how I use it.
`
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {super.onViewCreated(view, savedInstanceState)

    pagerAdapter = StoryBoardStatsFragmentPagerAdapter(activity!!.supportFragmentManager)

    if (storyResponse.likedusers.isNotEmpty()) {
        pagerAdapter.addFragment(StoryDetailsTabFragment.newInstance(
                StoryDetailsTabFragment.TabType.LIKES, storyResponse, this),
                storyResponse.likeCount.toString().plus(" likes"))
    }

    if (storyResponse.viewedusers.isNotEmpty()) {
        pagerAdapter.addFragment(StoryDetailsTabFragment.newInstance(
                StoryDetailsTabFragment.TabType.VIEWS, storyResponse, this),
                storyResponse.viewCount.toString().plus(" views"))
    }

    viewPager.offscreenPageLimit = 1
    viewPager.adapter = pagerAdapter

    tabs.setupWithViewPager(viewPager)
}

override fun onDataLoaded() {
    viewPager.post {
        behavior = ViewPagerBottomSheetBehavior.from(container)

        behavior.isHideable = true
        behavior.setBottomSheetCallback(object : ViewPagerBottomSheetBehavior.BottomSheetCallback() {
            override fun onSlide(bottomSheet: View, slideOffset: Float) {
                val percent = slideOffset * 100
                if (percent <= 45 && wasExpanded)
                    behavior.state = ViewPagerBottomSheetBehavior.STATE_HIDDEN
            }

            override fun onStateChanged(bottomSheet: View, newState: Int) {
                if (newState == BottomSheetBehavior.STATE_EXPANDED)
                    wasExpanded = true

                if (newState == BottomSheetBehavior.STATE_HIDDEN)
                    router.clearStackFragment()
            }
        })

        BottomSheetUtils.setupViewPager(viewPager) {
            router.clearStackFragment()
        }
    }
}`

from viewpagerbottomsheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.