Comments (6)
Is this for client side decorations or server side ones?
Server side shadows should not exist in terms of hitbox detection, e.g. dropping something there should land on whatever is behind those shadows.
from labwc.
Both CSD ((gthumb) and SSD (thunar).
Maybe source windows's shadow are not hitboxes, but they're "opaque": window bellow don't receive drops through them.
screenshot_2024-05-19-18:45:04.webm
from labwc.
Feels like there are two options:
- Decide that DND doesn't work through drop-shadows
- Overload
get_cursor_context()
to optionally ignore SSD drop-shadows. It's possible this could be done for CSD, but is likely to be hacky.
I prefer (1).
The disadvantage of (2) it may result in different behaviors depending on SSD/CSD, and it add complexity to an already complex code-path (get_cursor_context()
)
Ref:
from labwc.
SSD shadows should really not get detected:
Line 220 in 89589f1
Maybe this is actually about the invisible resize area?
@Arnaudv6 does the same happen with server side decorations when you disable shadows?
from labwc.
@Consolatis yes it does, good catch, sorry my bug was unspecific
from labwc.
Hm.. we need to detect the invisible resize area to well, resize the window.
Maybe we can either disable it or also set point_accepts_input
temporarily when in dnd mode. As far as I remember we do have a function that disables the dnd icon surface during hitbox detection already so we could likely hook into there.
from labwc.
Related Issues (20)
- Feature request: Unmaximize
- Feature request: focus/urgency handling for new/activating windows HOT 6
- Do not run dbus-update-activation-environment if dbus implementation is dbus-broker HOT 1
- Various issues with running labwc within a VM since moving to wlroots 0.17 HOT 4
- Inconsistent use of `_` and `-` in filenames HOT 4
- magnifier: improve performance by preventing useless rendering when enabled HOT 1
- Feature Request: Swap all windows from one monitor with the windows from another monitor HOT 1
- show/hide top layer more smartly HOT 5
- SSD: `SetDecorations 'full'` does not work without `forceSSD.action="yes"` HOT 1
- Add XKB_DEFAULT_VARIANT example to docs/environment HOT 1
- Terraria Steam version migrates from primary to secondary display on Alt-Tab HOT 2
- How to fine-tune options for nested usage? HOT 3
- How to force a screen refresh? HOT 4
- Is it possible to customize nested labwc window title? HOT 3
- `forceSSD="no"` not working as expected with pcmanfm-qt in CSD mode
- View matching broken for ForEach action HOT 2
- How to hide the titlebar? HOT 4
- Set squared SSD corners when SSD client is tiled and notified about being tiled HOT 1
- Is it possible to disable the ALT+drag feature? HOT 2
- Is it possible to enable qt6-virtualkeyboard HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from labwc.