Git Product home page Git Product logo

Comments (6)

Consolatis avatar Consolatis commented on June 2, 2024

Is this for client side decorations or server side ones?

Server side shadows should not exist in terms of hitbox detection, e.g. dropping something there should land on whatever is behind those shadows.

from labwc.

Arnaudv6 avatar Arnaudv6 commented on June 2, 2024

Both CSD ((gthumb) and SSD (thunar).
Maybe source windows's shadow are not hitboxes, but they're "opaque": window bellow don't receive drops through them.
screenshot_2024-05-19-18:45:04.webm

from labwc.

johanmalm avatar johanmalm commented on June 2, 2024

Feels like there are two options:

  1. Decide that DND doesn't work through drop-shadows
  2. Overload get_cursor_context() to optionally ignore SSD drop-shadows. It's possible this could be done for CSD, but is likely to be hacky.

I prefer (1).

The disadvantage of (2) it may result in different behaviors depending on SSD/CSD, and it add complexity to an already complex code-path (get_cursor_context())

Ref:

from labwc.

Consolatis avatar Consolatis commented on June 2, 2024

SSD shadows should really not get detected:

scene_buf->point_accepts_input = never_accepts_input;

-> https://gitlab.freedesktop.org/wlroots/wlroots/-/blob/0.17/types/scene/wlr_scene.c?ref_type=heads#L1059-1106

Maybe this is actually about the invisible resize area?
@Arnaudv6 does the same happen with server side decorations when you disable shadows?

from labwc.

Arnaudv6 avatar Arnaudv6 commented on June 2, 2024

@Consolatis yes it does, good catch, sorry my bug was unspecific

from labwc.

Consolatis avatar Consolatis commented on June 2, 2024

Hm.. we need to detect the invisible resize area to well, resize the window.

Maybe we can either disable it or also set point_accepts_input temporarily when in dnd mode. As far as I remember we do have a function that disables the dnd icon surface during hitbox detection already so we could likely hook into there.

from labwc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.