Comments (5)
It does have a license it's just not made obvious. Not a big fan of sticking licenses into people's faces like some projects do. If you read the top comment in vi.c the writing is of ISC open source license.
from nextvi.
Thank you very much.
from nextvi.
By the way @Arkaeriit last commit ironically did not end there. Well I always find something off. Anyway pls update cause regex may have (very rare bug). Apparently while checking all that stuff, I found another performance improvement, placing https://github.com/kyx0r/nextvi/blob/master/regex.c#L387 above the goto label causes the compiler to enable extra set of optimizations removing redundant memory reads. Now it can flow everything through eax register, this cuts down the cost by another ~8-10 million Irefs depending on the hardware. Pretty good.
from nextvi.
Though clang is pretty terrible optimizing this code, it does too many memory reloads, it's trying to be too smart. Gcc seems to be a lot more context aware. So yeah wouldn't reccomend clang for best performance. It feels like I've always gotta fight compiler cause it always finds a way to generate some crap, don't know who are those people saying that handmade assembly code is very hard to beat compiler, I look compiler explorer and it's a joke. It's definitely better than 5 years ago, but it might be at the peak of it's evolution now. I think part of the problem stems from grinding the compilers to optimize bad code more than try to optimize better already optimized C code. Like for example it is not smart enough to align some VLAs from int sized down to char* thus removing the need for instructions like "mov ebx, dword ptr [r10 + 4*rdi]" down to "mov ebx, dword ptr [r10+rdi]" which seems like might be better as it saves entire multiplication, should be easier to compute and branch predict. Though in modern hardware that may not always be the case.
from nextvi.
Thanks for the update, I will rebase my commits on them. Nice work optimizing the code for performance. Not a lot of peoples do it nowadays.
from nextvi.
Related Issues (20)
- segfault when trying to edit file that doesnt exist or is a directory HOT 3
- stdin pipe breaks all syntax highlighting HOT 1
- Issues with stdin_pipe HOT 14
- Is gf bind in normal mode that edits the file whose address is under the cursor, a thing in Nextvi? HOT 6
- arrowkeys_normal.patch shouldn't exit insert mode HOT 24
- Remove variable length arrays HOT 14
- arrowkeys_insert: the first time entering command mode, the command bar is broken until you type something HOT 1
- gcc warning HOT 2
- visual mode equivalent? HOT 2
- ec_closebuf segfaults if it is the only remaining buffer HOT 1
- Float without leading zero HOT 2
- a way to change how big tabs are HOT 1
- soft line wrap? HOT 2
- implementing vim-like dw HOT 3
- stdin_pipe: lockup if stdin is terminal HOT 5
- Skip command confirmation when only one line HOT 1
- arrowkeys_insert: cursor position is wrong when moving up or down a line after typing something HOT 6
- Segmentation fault HOT 3
- Edge case of missing filename HOT 3
- ex "!" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nextvi.