Git Product home page Git Product logo

Comments (4)

renanrodrigo avatar renanrodrigo commented on August 16, 2024

We'll generate:

  • error 404 if the DPID does not exist
  • error 400 if the body is malformed (invalid fields)
  • error 400 if any of the values can't be applied to the flowmod

from flow_manager.

ajoaoff avatar ajoaoff commented on August 16, 2024

Invalid fields or fields with invalid values are not yet treated.

from flow_manager.

ajoaoff avatar ajoaoff commented on August 16, 2024

If an inexistent field (like an invalid or not implemented action) is sent, a 500 error is returned. A better error code should be returned in such cases.

from flow_manager.

ajoaoff avatar ajoaoff commented on August 16, 2024

We'll generate:

  • error 404 if the DPID does not exist
  • error 400 if the body is malformed (invalid fields)
  • error 400 if any of the values can't be applied to the flowmod

When testing the last item, to see what was returned when an invalid value was sent (I tried a string where an integer is required) and the return code was 200. Kytos log showed a PackException when trying to pack the string to integer.
So, when the FlowMod is instantiated, the values are not validated, so no error occurs, the FlowMod is put in the controller's buffer and flow_manager returns no error code. The controller, asynchronously, reads the FlowMod from the buffer and, when trying to pack it, receives a PackException. The error is never returned to the user and the controller crashes.

from flow_manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.