Git Product home page Git Product logo

Comments (6)

kyleweiner avatar kyleweiner commented on June 18, 2024

Hi, @OuSS-90. Thanks for the kind words. I'll add a longPressEnded callback (that executes immediately after a long press gesture ends) in the next release.

from kwstepper.

OuSS-90 avatar OuSS-90 commented on June 18, 2024

Thank you ๐Ÿ‘

from kwstepper.

kyleweiner avatar kyleweiner commented on June 18, 2024

@OuSS-90 Check out v2.4.0 when you have a moment.

from kwstepper.

OuSS-90 avatar OuSS-90 commented on June 18, 2024

Thank you very much ๐Ÿ‘

from kwstepper.

OuSS-90 avatar OuSS-90 commented on June 18, 2024

I fixed some code for longPress.
When there is long press, usually we don't want increment and decrement to be called so i added this code in both incrementValue() and decrementValue():

// Increment function
if longPressTimer == nil {
   delegate?.KWStepperDidIncrement?()
    incrementCallback?(self)
 }

// decrement function
if longPressTimer == nil {
     delegate?.KWStepperDidDecrement?()
     decrementCallback?(self)
} 

basically i call delegate only if there is no longpress

from kwstepper.

kyleweiner avatar kyleweiner commented on June 18, 2024

Thanks for the update. If thatโ€™s what youโ€™re after, a flag to indicate when a long press gesture is happening would make more sense. Then, you can guard against doing additional work (such as hitting the backend) in your callbacks. Or, you can try #7 (comment), which avoids needing to concern yourself with the long press gesture entirely. For the former, please feel free to open another issue or submit a pull request. I'm not certain this feature is within the scope of the project though.

from kwstepper.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.