Git Product home page Git Product logo

Comments (5)

hoke-t avatar hoke-t commented on May 18, 2024

Implemented here: https://github.com/hoke-t/BackgroundMusic/tree/Decibel

Will submit pull request once #27 is accepted (or denied)

from backgroundmusic.

kyleneideck avatar kyleneideck commented on May 18, 2024

Thanks, @hoke-t. I haven't tested https://github.com/hoke-t/BackgroundMusic/tree/Decibel yet, but I just read through it and it looks good to me. Just two minor things:

  • When you moved the new files to BGMApp/BGMApp/Music Players you forgot to git rm the copies in BGMApp/BGMApp.
  • Would it be better to link to https://sbooth.org/Decibel/ instead of http://sbooth.org/Decibel/ in the README? (If so, we should do the same for the link to VOX.)

from backgroundmusic.

DotTheI avatar DotTheI commented on May 18, 2024

Second this request

from backgroundmusic.

hoke-t avatar hoke-t commented on May 18, 2024

Working on it now.

from backgroundmusic.

hoke-t avatar hoke-t commented on May 18, 2024

Sorry the PR failed check, will fix it when I get a chance and resubmit.

from backgroundmusic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.