Git Product home page Git Product logo

Comments (2)

rpatters1 avatar rpatters1 commented on June 29, 2024

This seems like a reasonable step to me. I would suggest that it derive from std::runtime_error.

As a side note, I went looking to see how it would differ from LuaException and discovered this:

inline void enableExceptions(lua_State* L) noexcept
{
#if LUABRIDGE_HAS_EXCEPTIONS
    LuaException::enableExceptions(L);
#else
    unused(L);

    LUABRIDGE_ASSERT(false); // Never call this function when exceptions are not enabled.
#endif
}

Would it not be safer to do it this way? (Thinking about the principal of failing early, this would fail at compile time rather than run time.):

#if LUABRIDGE_HAS_EXCEPTIONS
inline void enableExceptions(lua_State* L) noexcept
{
    LuaException::enableExceptions(L);
}
#endif

from luabridge3.

kunitoki avatar kunitoki commented on June 29, 2024

Yes makes sense

from luabridge3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.