Comments (15)
0xFelix
commented on June 12, 2024
1
@akrejcir @ksimon1 I'll close this issue and we'll keep the value. Any objections?
from common-instancetypes.
kubevirt-bot
commented on June 12, 2024
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
from common-instancetypes.
kubevirt-bot
commented on June 12, 2024
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
from common-instancetypes.
kubevirt-bot
commented on June 12, 2024
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
from common-instancetypes.
kubevirt-bot
commented on June 12, 2024
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from common-instancetypes.
0xFelix
commented on June 12, 2024
/reopen
from common-instancetypes.
kubevirt-bot
commented on June 12, 2024
@0xFelix: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from common-instancetypes.
0xFelix
commented on June 12, 2024
/remove-lifecycle rotten
from common-instancetypes.
akrejcir
commented on June 12, 2024
The value was set in this PR: kubevirt/common-templates#164
The reason for 1 hour termination grace period is probably that windows updates can be triggered on shutdown and they can take a long time.
from common-instancetypes.
0xFelix
commented on June 12, 2024
Does it have to be that high, or can we lower the value? (e.g. only half of it, 1800 secs). Can you tell how long a shutdown usually takes?
from common-instancetypes.
ksimon1
commented on June 12, 2024
as @akrejcir said, the period is so high, because termination of windows workloads (not only windows updates, but user workloads too) can take a lot of time. I would vote to keep it that way.
from common-instancetypes.
akrejcir
commented on June 12, 2024
No objections. I will add a comment to the source code explaining why this value was chosen.
from common-instancetypes.
0xFelix
commented on June 12, 2024
Great, please add this issue to the Fixes section of your PR.
from common-instancetypes.
akrejcir
commented on June 12, 2024
The PR was merged.
/close
from common-instancetypes.
kubevirt-bot
commented on June 12, 2024
@akrejcir: Closing this issue.
In response to this:
The PR was merged.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from common-instancetypes.
Related Issues (20)
- `centos.stream9` should not enable EFI and secureboot until the cloud images support UEFI
- Reconsider default huge page requirement for compute and memory IT classes HOT 9
- Windows 11 preferences require only one core
- Consider merging CX and N use-cases
- Sync stable branch releases with the corresponding `kubevirt/kubevirt` and `kubevirt/ssp-operator` stable release branches
- Flatten the repository structure HOT 1
- Windows 11 and 2k22 use TPMs without persistent storage HOT 6
- Resolve TODOs in `functest.sh`
- Add test coverage for resource labels HOT 4
- Add `instancetype.kubevirt.io/common-instancetype-version` annotation to each generated resource
- Add minimum resource requirements to each preference
- Some resources still using `instancetype.kubevirt.io/v1alpha2`
- Use `osinfo` to determine requirements for OS derived preferences HOT 4
- Simplify the `O` instance type class to inherit directly from `U`
- Pin release-0.3 to KubeVirt `v1.0.0` once released HOT 2
- O series description typo
- Make `instancetype.kubevirt.io/class` and `instancetype.kubevirt.io/version` labels
- Add `micro` size for `U` instance type series to replace `server.micro`
- Remove deprecated legacy instance types
- Missing labels on `VirtualMachineClusterInstancetype` o1 series - cpu/memory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from common-instancetypes.