Git Product home page Git Product logo

Comments (6)

sftim avatar sftim commented on July 25, 2024

Thanks for mentioning this. What's not right about the documentation, in your opinion, @thinkvatsa?

/language en

from website.

thinkvatsa avatar thinkvatsa commented on July 25, 2024

As per documentation, for the secret type: kubernetes.io/basic-auth, they keys (username, password) are validated during secret creation.

However, I am able to generate this secret of type kubernetes.io/basic-auth without mentioning password key in the manifest.

Is the documentation correct? If yes, then validation is missing? @sftim

from website.

sftim avatar sftim commented on July 25, 2024

It sounds like you're saying that specifically

The Kubernetes API verifies that the required keys are set for a Secret of this type.

is wrong. As well as removing that text, we make it clear that “must” means ”you are expected to ensure this” and not “your cluster enforces this“.

/triage accepted


If you want the cluster to enforce that those keys are set, you could make a feature request @thinkvatsa.

As an aside: would be nice to document some ValidatingAdmissionPolicies that do enforce this rule.

from website.

pegasas avatar pegasas commented on July 25, 2024

/assign @pegasas
I will create a PR for fixing this.

from website.

sftim avatar sftim commented on July 25, 2024

Fixed in #46717
/close

from website.

k8s-ci-robot avatar k8s-ci-robot commented on July 25, 2024

@sftim: Closing this issue.

In response to this:

Fixed in #46717
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.