Comments (9)
@shannonxtreme Can you please revise the following guidance:
Our goal to have ≤ 100 open PRs in the project
Our goal is to have approximately 100 PRs open for English language and site-wide changes. This is an important distinction because we have a lot of localization PRs that aren't under the purveiw of PR wrangling, but are rather the domain of localization teams, and their resources are decidely smaller than the SIG-wide reveiwers pool.
from website.
Yes @priyanshsao but maybe let's get confirmation in these comments about where exactly to put this information before you do a PR!
from website.
This content should probably go into https://kubernetes.io/docs/contribute/review/reviewing-prs/ and potentially be linked to from https://github.com/kubernetes/community/blob/master/contributors/guide/review-guidelines.md (although that's for all contributors and not just docs)
Can we put it into https://k8s.dev/docs/ and link there? It'll be English-only, but that's OK: everyone who works on PRs should have at least some familiarity with English.
from website.
/triage accepted
from website.
I agree with @sftim's point since filtering and contributing also fit into the scope of the wider project. Amending k8s.dev & linking it somewhere in our contributing docs should help.
from website.
Thanks Natali, added. @divya-mohan0209 @sftim for the k8s.dev one, I was looking at that and it didn't seem like we had a "guidelines for PR reviews" type document there. That's why I ended up in the k/community repo, which does have that guidance. Do you think that it's worth creating a new page in k8s.dev/docs instead?
from website.
can i work on this issue?
from website.
@shannonxtreme : Good point! I would suggest that it be added as a section into the pull requests guide on the k8s.dev site since there's already information that is very similar to the information that we're trying to put forth. Thoughts?
from website.
@divya-mohan0209 That page seems to be tightly focused on submitting a PR, not reviewing one. What about https://www.kubernetes.dev/docs/guide/contributing/#code-review ? There's a section there for reviewers about the expectations for them. Maybe a subsection under Code review for PR reviewer guidelines?
from website.
Related Issues (20)
- [ja] Translate content/ja/blog/_posts/2024-06-06-10-Years-of-Kubernetes/ into Japanese HOT 2
- Add a deprecated flag and more details of the reason/alternatives for "EndpointSlice.addressType: FQDN" HOT 3
- The API server doesn't have a cloud provider flag HOT 1
- Using kubectl to Create a Deployment HOT 4
- Pod Phase "Failed" Explanation is Misleading HOT 5
- Improvement for k8s.io/docs/tasks/administer-cluster/configure-upgrade-etcd/ HOT 9
- 🚯 HOT 2
- etcd task page unclear on difference between `etcdctl` and `etcdutl` HOT 8
- Add a note that after a cluster upgrade using kubeadm, backup files will need to be cleared manually. HOT 12
- [pt-br] Localize docs/tasks/access-application-cluster/web-ui-dashboard/ HOT 4
- IPv4/IPv6 dual-stack - wrong references to '.spec.ClusterIP/s' (instead of '.spec.clusterIP/s') fields in service API objects HOT 6
- [ja] Translate content/en/blog/_posts/2024-05-20-cloud-provider-migration.md into Japanese HOT 1
- kubeadm: add note about a bug in the PublicKeysECDSA feature gate HOT 6
- Description of managedFields.fieldsV1 in ObjectMeta is garbled HOT 4
- Download Kubernetes HOT 4
- Enhance `kubectl set image` documentation: Improve summary, add usage scenarios, and compare with `kubectl edit` HOT 6
- Missing Persistent Volume and Storage Class Configuration in MySQL-WordPress Tutorial HOT 3
- Doc for `apiserver_request_duration_seconds` removed, but metric is still in code HOT 2
- Pull an Image from a Private Registry HOT 2
- Revise blog submission guidelines for the new "author" metadata format HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from website.