Git Product home page Git Product logo

Comments (9)

natalisucks avatar natalisucks commented on June 16, 2024 1

@shannonxtreme Can you please revise the following guidance:

Our goal to have ≤ 100 open PRs in the project

Our goal is to have approximately 100 PRs open for English language and site-wide changes. This is an important distinction because we have a lot of localization PRs that aren't under the purveiw of PR wrangling, but are rather the domain of localization teams, and their resources are decidely smaller than the SIG-wide reveiwers pool.

from website.

shannonxtreme avatar shannonxtreme commented on June 16, 2024 1

Yes @priyanshsao but maybe let's get confirmation in these comments about where exactly to put this information before you do a PR!

from website.

sftim avatar sftim commented on June 16, 2024

This content should probably go into https://kubernetes.io/docs/contribute/review/reviewing-prs/ and potentially be linked to from https://github.com/kubernetes/community/blob/master/contributors/guide/review-guidelines.md (although that's for all contributors and not just docs)

Can we put it into https://k8s.dev/docs/ and link there? It'll be English-only, but that's OK: everyone who works on PRs should have at least some familiarity with English.

from website.

divya-mohan0209 avatar divya-mohan0209 commented on June 16, 2024

/triage accepted

from website.

divya-mohan0209 avatar divya-mohan0209 commented on June 16, 2024

I agree with @sftim's point since filtering and contributing also fit into the scope of the wider project. Amending k8s.dev & linking it somewhere in our contributing docs should help.

from website.

shannonxtreme avatar shannonxtreme commented on June 16, 2024

Thanks Natali, added. @divya-mohan0209 @sftim for the k8s.dev one, I was looking at that and it didn't seem like we had a "guidelines for PR reviews" type document there. That's why I ended up in the k/community repo, which does have that guidance. Do you think that it's worth creating a new page in k8s.dev/docs instead?

from website.

priyanshsao avatar priyanshsao commented on June 16, 2024

can i work on this issue?

from website.

divya-mohan0209 avatar divya-mohan0209 commented on June 16, 2024

@shannonxtreme : Good point! I would suggest that it be added as a section into the pull requests guide on the k8s.dev site since there's already information that is very similar to the information that we're trying to put forth. Thoughts?

from website.

shannonxtreme avatar shannonxtreme commented on June 16, 2024

@divya-mohan0209 That page seems to be tightly focused on submitting a PR, not reviewing one. What about https://www.kubernetes.dev/docs/guide/contributing/#code-review ? There's a section there for reviewers about the expectations for them. Maybe a subsection under Code review for PR reviewer guidelines?

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.