Git Product home page Git Product logo

Comments (16)

neolit123 avatar neolit123 commented on May 24, 2024 2

@xmudrii @saschagrunert am i reading correctly that kubeadm continues to depend on kubelet and kubectl? https://github.com/kubernetes/release/blob/master/cmd/krel/templates/latest/metadata.yaml

Yes, that's correct for the current state. I guess the intention was that it makes not much sense to use kubeadm without the kubelet. But maybe it does? I assume we can drop those dependencies. Do you mind proposing that in k/release so we can discuss it there?

thanks.
yes, it does make sense to remove the dep in terms of upgrade process, because kubeadm should be upgraded before kubelet and right now users need to "hold" packages. it has been a problem for a long time.
the kubectl dependency is not needed.
i will log the ticket in a bit.

i think we should drop these dependencies if possible given the new repository scheme we moved to. maybe for 1.30.

  • kubeadm can continue to depend on cri-tools, but not on kubelet and kubectl

Do we have a plan to remove this dependency? We have golang code to work directly with the CRI.

today kubeadm depends on crictl from critools for talking to the container runtime on the host, but there is no problem during upgrade as the one explained above for the kubelet. yet, preferably we should continue to maintain the cri-tools package similarly to kubernetes-cni, so that these installation parts are automated for users at least.

from website.

neolit123 avatar neolit123 commented on May 24, 2024 2

kubernetes/release#3480

from website.

dipesh-rawat avatar dipesh-rawat commented on May 24, 2024

Page mentioned in issue: https://v1-27.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/
/language en

(Equivalent page in current version of docs: https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade)

from website.

dipesh-rawat avatar dipesh-rawat commented on May 24, 2024

/retitle Unable to upgrade kubeadm using 'apt' without unholding kubectl and kubelet
/sig cluster-lifecycle

from website.

sftim avatar sftim commented on May 24, 2024

/kind bug

from website.

sftim avatar sftim commented on May 24, 2024

/priority important-longterm

(either important to triage or, if accepted, important to fix)

from website.

neolit123 avatar neolit123 commented on May 24, 2024

as descirbed here, I can only do so by also unholding kubectl and kubelet due to package dependencies.

i don't recall this being a requirement.
if someone wish they can send an update, but please update all relevant places where there are similar unhold commands.

/triage accepted

from website.

sftim avatar sftim commented on May 24, 2024

If this looks like a packaging issue, please let us know. In particular I don't think kubectl should depend on kubeadm.

from website.

dev-johnn avatar dev-johnn commented on May 24, 2024

I can sned an update for this.

/assign

from website.

neolit123 avatar neolit123 commented on May 24, 2024

@dev-johnn please hold the PRs for this.

@jhannink

kubeadm / kubelet / kubectl packages shouldnot be cross-dependent. this is an old problem, but now it should be easier to fix given k8s versions are in separate repos.
https://github.com/search?q=repo%3Akubernetes%2Frelease+kubeadm+depends+on+kubelet&type=issues

so what you can do is log a k/release ticket, if the maintainers reject it, the docs can be updated.
if it's accepted this k/website ticket can be closed.

make sure you cross ref a k/release ticket here.

from website.

jhannink avatar jhannink commented on May 24, 2024

Correct, there are no dependencies for versions of kubeadm>=1.26. Only the 25 > 26 upgrade has this documentation problem from my perspective

from website.

neolit123 avatar neolit123 commented on May 24, 2024

Correct, there are no dependencies for versions of kubeadm>=1.26. Only the 25 > 26 upgrade has this documentation problem from my perspective

that's surprising, are you sure that newer version don't have the same problem?
if it's only a 25 -> 26 problem then we should not make any changes to the docs, ideally because 1.26 just went out of support
https://kubernetes.io/releases/

from website.

neolit123 avatar neolit123 commented on May 24, 2024

@xmudrii @saschagrunert am i reading correctly that kubeadm continues to depend on kubelet and kubectl?
https://github.com/kubernetes/release/blob/master/cmd/krel/templates/latest/metadata.yaml

i think we should drop these dependencies if possible given the new repository scheme we moved to. maybe for 1.30.

  • kubeadm can continue to depend on cri-tools, but not on kubelet and kubectl
  • kubectl doesn't depend on anything which is OK
  • kubelet depending on kubernetes-cni is OK (also i see iptables is hardcoded in the spec)

if you give me a green light i can PR the metadata.yaml file.

from website.

saschagrunert avatar saschagrunert commented on May 24, 2024

@xmudrii @saschagrunert am i reading correctly that kubeadm continues to depend on kubelet and kubectl? https://github.com/kubernetes/release/blob/master/cmd/krel/templates/latest/metadata.yaml

Yes, that's correct for the current state. I guess the intention was that it makes not much sense to use kubeadm without the kubelet. But maybe it does? I assume we can drop those dependencies. Do you mind proposing that in k/release so we can discuss it there?

i think we should drop these dependencies if possible given the new repository scheme we moved to. maybe for 1.30.

  • kubeadm can continue to depend on cri-tools, but not on kubelet and kubectl

Do we have a plan to remove this dependency? We have golang code to work directly with the CRI.

from website.

neolit123 avatar neolit123 commented on May 24, 2024

solved at k/release
let's see what happens with the 1.30+ packages.

/close

from website.

k8s-ci-robot avatar k8s-ci-robot commented on May 24, 2024

@neolit123: Closing this issue.

In response to this:

solved at k/release
let's see what happens with the 1.30+ packages.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.