Git Product home page Git Product logo

Comments (6)

k8s-ci-robot avatar k8s-ci-robot commented on July 24, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

from kubernetes.

neolit123 avatar neolit123 commented on July 24, 2024

/sig node

from kubernetes.

ffromani avatar ffromani commented on July 24, 2024

hi, thanks for the report. It's possible we have some issues in handling device plugins reconnections. Do we have a simple reproducer by any chance?

from kubernetes.

913871734 avatar 913871734 commented on July 24, 2024

Actually, It is hard to reproduce a same condition, I'm not sure the root reason is about reconnections, but I think the mechanism of reconnection between kubelet and plugin could be improved(I haven't found the reconnection action on kubelet. ), isn't it ?

from kubernetes.

ffromani avatar ffromani commented on July 24, 2024

Actually, It is hard to reproduce a same condition, I'm not sure the root reason is about reconnections, but I think the mechanism of reconnection between kubelet and plugin could be improved(I haven't found the reconnection action on kubelet. ), isn't it ?

It is a responsability of the device plugin to handle reconnections, both on crashes/restarts of the device plugin itself and tolerating kubelet restarts: https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#handling-kubelet-restarts

I'd be more than supportive to make the kubelet code more robust in presence of such events, but we need to narrow down the perimeter a bit, hence my previous question.

from kubernetes.

913871734 avatar 913871734 commented on July 24, 2024

Thanks for your support, I'm agree with your opinion. Here is some additional notes:

  1. https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#handling-kubelet-restarts Kubelet re-registers the restore connection function by monitoring the sock file in the plugin directory. I have confirmed that there is no problem with the function. But when this issue occurred, I found that the sock file in the directory was normal and had not been removed. However, I restarted kubelet and found that the plugin was re-registered and the kubelet value was correctly updated.
  2. In the kubelet logs, I did not clearly observe logs of disconnection from the plugin, I just found the log like this:
    image
    image
    However, the time of these two logs is after the failure occurs. :(
  3. For details about this failure, I also carefully reviewed the plugin code and raised relevant issues to them. For details, please refer to :https://github.com/Mellanox/k8s-rdma-shared-dev-plugin/issues/109

from kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.