[Flaking Test] ci-kubernetes-unit (Unexpected event resourceVersion 2 less than or equal to bookmark 2) about kubernetes HOT 10 CLOSED

The fix for it is already approved.

from kubernetes.

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

from kubernetes.

/sig storage
@kubernetes/release-team-release-signal

from kubernetes.

/sig api-machinery

from kubernetes.

/cc @serathius @p0lyn0mial

This started last week, but it seems to be fairly rare, so might be a consequence of something a bit earlier.

The value of "2" suggests that it's happening on the first event, and my brain goes towards: https://github.com/kubernetes/kubernetes/pull/124754/files

@p0lyn0mial - will you be able to take a look at it?

from kubernetes.

@p0lyn0mial - will you be able to take a look at it?

sure, I will have a look.

/assign @p0lyn0mial

from kubernetes.

We chatted with @p0lyn0mial about that offline and it seems like a real correctness issue.

Regression indeed introduced by https://github.com/kubernetes/kubernetes/pull/124754/files

We have a race with setting RV in watchcache and incoming events.

The current explanation is:

1. watchcache initializeds with RV=N
2. an event comes with RV=N+1 [but wasn't yet dispatched]
3. the polling introduced in that PR catches RV=N+1
4. only then the event (with RV=N+1) is received

from kubernetes.

@wojtek-t @p0lyn0mial So it is a release blocker, then? (Upcoming alpha 1 release cut scheduled for tomorrow)

from kubernetes.

@wojtek-t @p0lyn0mial So it is a release blocker, then? (Upcoming alpha 1 release cut scheduled for tomorrow)

I don't know what the release policy is but we might have a potential fix for this issue.

from kubernetes.

@wojtek-t @p0lyn0mial So it is a release blocker, then? (Upcoming alpha 1 release cut scheduled for tomorrow)

This is a real correctness bug introduced 2 weeks ago. I'm not sure what's our policy is for alpha releases, but it sounds like a potential blocker to me.

from kubernetes.