As of go 1.22, there's no need to use the unsafe package for string to bytes conversion about kubernetes HOT 6 OPEN

@nikzayn of course

from kubernetes.

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

from kubernetes.

/sig api-machinery

from kubernetes.

Good catch! Why should we use unsafe packages before?

from kubernetes.

@cyclinder For string to bytes conversion, before go 1.22, type casting is not 0 memory allocation, and indeed is slower than the unsafe way:
go 1.21 (or before):

╰─± go test -run=xxx -bench=.  ./...
goos: darwin
goarch: amd64
pkg: github.com/josestg/zerocast
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkStringToBytesTypeCasting-10                    7207893               151.1 ns/op          1792 B/op          1 allocs/op
BenchmarkStringToBytesUnsafe-10               1000000000               0.3904 ns/op          0 B/op          0 allocs/op

but not the case for go 1.22, type casting is 0 memory allocation now, faster and safer:

╰─± go test -run=xxx -bench=.  ./...
goos: darwin
goarch: amd64
pkg: github.com/josestg/zerocast
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkStringToBytesTypeCasting-12    	                1000000000	         0.2581 ns/op	       0 B/op	       0 allocs/op
BenchmarkStringToBytesUnsafe-12            	1000000000	         0.4422 ns/op	       0 B/op	       0 allocs/op

from kubernetes.

@Aden-Q Can I take this up thanks for the valuable description. I explored something good today. Thanks.

/assign

from kubernetes.