Query on ContinueToken about apiserver HOT 8 CLOSED

@stevekuznetsov @logicalhan tagging you folks since I see you have commit history on this file :).(sorry if I mistagged, pls help tag right folks who may know some context on this)

from apiserver.

@mehvaibh could you provide some more details for what you are trying to achieve? The purpose of the ContinueToken is to encode how far along a LIST call is during pagination, so that the process is stateless on the server. During a paginated call, the server encodes where it left off in the last request into the ContinueToken and a client passes that token back, verbatim, in the ?continue= query parameter on their next call. The StartKey is used to drive the next paginated call.

from apiserver.

Thanks for reply @stevekuznetsov !

My query is regarding this comment on continueToken

"This is a public API struct and cannot change."

I'm evaluating adding one more param to this struct (can discuss more if required afterwards) but above comments suggests this continueToken struct should not be changed(pls correct me if I misunderstood).
My query is can we add a new param to this struct ?

Based on my testing (explained in detailed in previous comment) adding a new param does not break compatibility.

from apiserver.

It would have to follow the same rules as any other public-facing API. If the behavior degrades gracefully with old servers perhaps it's OK, but I would suggest you write up a KEP for the change and get feedback from the API Machinery SIG as a whole.

from apiserver.

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

from apiserver.

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

from apiserver.

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

from apiserver.

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

from apiserver.