Comments (9)
I think the first option (https://github.com/kubernetes/website/tree/main/content/en/docs/doc-contributor-tools/linkchecker) could be adopted. It is simpler as it already uses the same underlying tool (htmltest
) that we currently use.
The first step is to add it as a CI job (either the same link checker as used in kubernetes/website or the existing Make rule we have). I don't think it makes sense to add it as a presubmit as links can break sporadically. Probably running the job 2x a day would be good so that we can get some signal that all links are OK.
from prow.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale
- Mark this issue or PR as rotten with
/lifecycle rotten
- Close this issue or PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from prow.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Close this issue or PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
from prow.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Reopen this issue or PR with
/reopen
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
from prow.
@k8s-triage-robot: Closing this issue.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied- After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied- After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closedYou can:
- Reopen this issue or PR with
/reopen
- Mark this issue or PR as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from prow.
/reopen
/lifecycle frozen
Here are tools I saw:
- K8s doc's Internal link checking tool
According to the doc, the tool
- Builds the site and generates output HTML in the
/public
directory of your localkubernetes/website
repository - Pulls the
wdjp/htmltest
Docker image - Mounts your local
kubernetes/website
repository to the Docker image - Scans the files generated in the
/public
directory and provides command line output when it encounters broken internal links
and its workflow seems similar to the current link checker in this Prow doc repo.
Lines 26 to 27 in 0d8946d
prow/site/check-broken-links.sh
Lines 22 to 30 in 0d8946d
- K8s doc's
linkchecker.py
While the above linkcheckers analyze whether the links in the Hugo-generated HTML files are working or not (404, ...),
this linkchecker performs sort of static analysis on markdown files.
And yes, it would be great to implement a new linkchecking Prow workflow
- for every PR, and/or
- executed periodically
from prow.
@jihoon-seo: You can't reopen an issue/PR unless you authored it or you are a collaborator.
In response to this:
/reopen
/lifecycle frozenHere are tools I saw:
- K8s doc's Internal link checking tool
According to the doc, the tool
- Builds the site and generates output HTML in the
/public
directory of your localkubernetes/website
repository- Pulls the
wdjp/htmltest
Docker image- Mounts your local
kubernetes/website
repository to the Docker image- Scans the files generated in the
/public
directory and provides command line output when it encounters broken internal linksand its workflow seems similar to the current link checker in this Prow doc repo.
Lines 26 to 27 in 0d8946d
prow/site/check-broken-links.sh
Lines 22 to 30 in 0d8946d
- K8s doc's
linkchecker.py
While the above linkcheckers analyze whether the links in the Hugo-generated HTML files are working or not (404, ...),
this linkchecker performs sort of static analysis on markdown files.
And yes, it would be great to implement a new linkchecking Prow workflow
- for every PR, and/or
- executed periodically
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from prow.
/reopen
Does not feel like an issue that should rot - either we think this is useful, or we should explicitly decide we don't want that.
from prow.
@petr-muller: Reopened this issue.
In response to this:
/reopen
Does not feel like an issue that should rot - either we think this is useful, or we should explicitly decide we don't want that.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from prow.
Related Issues (20)
- Prow issue: HOT 3
- Prow issue:48.086512,39.690118 HOT 3
- Add support for external collaborators to peribolos
- Prow issue:📅⚖️👁️✨🕯️⚔️📜🗝️🛡️ HOT 2
- implicit_self_approval: false should prevent suggesting PR author for approval
- Deck's build log lens should fail gracefully on large build-log.txt files.
- "Details" link for "tide" check on GitHub PRs doesn't work for PRs authored by bot users
- Feature Request: exclusive label sets HOT 3
- Feature Request: Issue Org Invitations HOT 1
- ProwJob CRD is too large HOT 5
- Blunderbus Shouldn't Assign Draft Pull Requests
- Expose job envrionments in prow.yaml #3 HOT 1
- I want to join this oganization HOT 2
- Prow issue: I am installing containerd 1.7.16 and kubernetes 1.30.0 on RHEL centos machines onpremise.The pods are unable to run HOT 4
- Renaming a presubmit job triggered builds on draft pull requests
- Allow renaming Prow's `test` container for individual jobs HOT 3
- prow: handle the case of re-triggering an expired GitHub workflow
- Prow issue: Bad invalid commit message for npm dependencies #28257 HOT 1
- Allow `ok-to-test` label to approve GitHub workflow runs for new contributors #25210 HOT 1
- Reporting periodic jobs failures to slack channel after number of consequent failures HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prow.